chrome/browser/external_protocol/external_protocol_handler_unittest.cc - Issue 2538353002: fix external protocol handling for OOPIFs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 2538353002: fix external protocol handling for OOPIFs (Closed)

Patch Set: remove unnecessary include Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/external_protocol/external_protocol_handler.cc ('k') | chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

index 4003a4e9c10bedfe4f5bc92d1a5eacf3badd56a9..e0c29f4d714b3dbbe6c3d7de2c6551cd9a6bd33d 100644

--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

@@ -73,7 +73,9 @@ class FakeExternalProtocolHandlerDelegate

has_prompted_ = true;

}

- void LaunchUrlWithoutSecurityCheck(const GURL& url) override {

+ void LaunchUrlWithoutSecurityCheck(

+ const GURL& url,

+ content::WebContents* web_contents) override {

ASSERT_EQ(block_state_, ExternalProtocolHandler::DONT_BLOCK);

ASSERT_NE(os_state_, shell_integration::IS_DEFAULT);

has_launched_ = true;