Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2391)

Unified Diff: chrome/browser/ui/external_protocol_dialog_delegate.cc

Issue 2538353002: fix external protocol handling for OOPIFs (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/external_protocol_dialog_delegate.cc
diff --git a/chrome/browser/ui/external_protocol_dialog_delegate.cc b/chrome/browser/ui/external_protocol_dialog_delegate.cc
index 63c0b6517bfea33eb01665c1747f12ca9ffa49c7..050021c40376371ab78c0dd36fac7ccc04cc2f69 100644
--- a/chrome/browser/ui/external_protocol_dialog_delegate.cc
+++ b/chrome/browser/ui/external_protocol_dialog_delegate.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/external_protocol_dialog_delegate.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
+#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
#include "components/strings/grit/components_strings.h"
@@ -65,8 +66,10 @@ void ExternalProtocolDialogDelegate::DoAccept(const GURL& url,
ExternalProtocolHandler::DONT_BLOCK);
}
- ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(
- url, render_process_host_id_, tab_contents_id_);
+ content::WebContents* web_contents =
+ tab_util::GetWebContentsByID(render_process_host_id_, tab_contents_id_);
+
+ ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(url, web_contents);
}
void ExternalProtocolDialogDelegate::DoCancel(const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698