chrome/test/data/auto_mailto_subframe.html - Issue 2538353002: fix external protocol handling for OOPIFs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/auto_mailto_subframe.html

Issue 2538353002: fix external protocol handling for OOPIFs (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body onload="javascript: window.location.href='mailto:mail@example.org';">

	4 D - This subframe automatically opens a mailto: link.
	alexmos 2016/12/01 19:21:14 What does the D refer to? The site from which thi What does the D refer to? The site from which this is opened? It's probably better to leave this generic, as future tests might load this file from other sites or reuse it differently. Similarly, the file name doesn't need to be so specific - just page_with_mailto.html would work. davidsac (gone - try alexmos) 2016/12/12 19:15:47 Done. Show quoted text On 2016/12/01 19:21:14, alexmos wrote: > What does the D refer to? The site from which this is opened? It's probably > better to leave this generic, as future tests might load this file from other > sites or reuse it differently. Similarly, the file name doesn't need to be so > specific - just page_with_mailto.html would work. Done.
	5 </body>

	6 </html>

OLD	NEW