chrome/browser/chromeos/customization_document.h - Issue 253833006: Add browser test for CustomizationWallpaperDownloader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/customization_document.h

Issue 253833006: Add browser test for CustomizationWallpaperDownloader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implemented set_retry_delay_for_testing. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « PRESUBMIT.py ('k') | chrome/browser/chromeos/customization_wallpaper_downloader.h » ('j') | chrome/browser/chromeos/customization_wallpaper_downloader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/customization_document.h

diff --git a/chrome/browser/chromeos/customization_document.h b/chrome/browser/chromeos/customization_document.h

index 97e166d82e193595447546e15faebff133f52f7b..7ad38dc834957802f0d420f183f31096ede815c2 100644

--- a/chrome/browser/chromeos/customization_document.h

+++ b/chrome/browser/chromeos/customization_document.h

@@ -196,6 +196,13 @@ class ServicesCustomizationDocument : public CustomizationDocument,

private:

friend struct DefaultSingletonTraits<ServicesCustomizationDocument>;

+ FRIEND_TEST_ALL_PREFIXES(CustomizationWallpaperDownloaderBrowserTest,

+ OEMWallpaperIsPresent);

+ FRIEND_TEST_ALL_PREFIXES(CustomizationWallpaperDownloaderBrowserTest,

+ OEMWallpaperRetryFetch);

+ // This class is used in tests.

+ friend class TestWallpaperImageURLFetcherCallback;

Daniel Erat 2014/04/30 21:23:06 can you remove the friends if you just add a publi

Alexander Alekseev 2014/05/04 23:30:56 Done.

typedef std::vector<base::WeakPtr<ServicesCustomizationExternalLoader> >

ExternalLoaders;