| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 163 'New code should not use ScopedAllowIO. Post a task to the blocking', | 163 'New code should not use ScopedAllowIO. Post a task to the blocking', |
| 164 'pool or the FILE thread instead.', | 164 'pool or the FILE thread instead.', |
| 165 ), | 165 ), |
| 166 True, | 166 True, |
| 167 ( | 167 ( |
| 168 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$", | 168 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$", |
| 169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", | 169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", |
| 170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", | 170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", |
| 171 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$", | 171 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$", |
| 172 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", | 172 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", |
| 173 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", |
| 173 ), | 174 ), |
| 174 ), | 175 ), |
| 175 ( | 176 ( |
| 176 'SkRefPtr', | 177 'SkRefPtr', |
| 177 ( | 178 ( |
| 178 'The use of SkRefPtr is prohibited. ', | 179 'The use of SkRefPtr is prohibited. ', |
| 179 'Please use skia::RefPtr instead.' | 180 'Please use skia::RefPtr instead.' |
| 180 ), | 181 ), |
| 181 True, | 182 True, |
| 182 (), | 183 (), |
| (...skipping 1311 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1494 builders.extend(['cros_x86']) | 1495 builders.extend(['cros_x86']) |
| 1495 | 1496 |
| 1496 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1497 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1497 # unless they're .gyp(i) files as changes to those files can break the gyp | 1498 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1498 # step on that bot. | 1499 # step on that bot. |
| 1499 if (not all(re.search('^chrome', f) for f in files) or | 1500 if (not all(re.search('^chrome', f) for f in files) or |
| 1500 any(re.search('\.gypi?$', f) for f in files)): | 1501 any(re.search('\.gypi?$', f) for f in files)): |
| 1501 builders.extend(['android_aosp']) | 1502 builders.extend(['android_aosp']) |
| 1502 | 1503 |
| 1503 return GetDefaultTryConfigs(builders) | 1504 return GetDefaultTryConfigs(builders) |
| OLD | NEW |