Add browser test for CustomizationWallpaperDownloader.

chrome/browser/chromeos/customization_wallpaper_downloader.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_WALLPAPER_DOWNLOADER_H_
 #define CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_WALLPAPER_DOWNLOADER_H_
 
 #include <string>
 
 #include "base/bind.h"
@@ skipping 35 matching lines @@
 
   virtual ~CustomizationWallpaperDownloader();
 
   // Start download.
   void Start();
 
   // net::URLFetcherDelegate
   virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
 
  private:
+  // This class is used in tests.
+  friend class TestWallpaperImageURLFetcherCallback;
+
+  // This is called in tests to modify (lower) retry delay.
+  void set_retry_delay_for_testing(double value) {

[Daniel Erat, 2014/04/30 21:23:06]

leave this as public; there's a presubmit check that _for_testing methods aren't
called from outside of tests. (you probably don't need to list the friend then,
right?)

also use base::TimeDelta instead of double. "double value" doesn't explain
anything about the units that are being used -- everyone calling this would need
to read the implementation to see what to pass.

[Alexander Alekseev, 2014/05/04 23:30:56]

Done.

+    retry_delay_seconds_ = value;
+  }
+
   // Start new request.
   void StartRequest();
 
   // Schedules retry.
   void Retry();
 
   // Called on UI thread.
   void OnWallpaperDirectoryCreated(scoped_ptr<bool> success);
 
   // Called on UI thread.
@@ skipping 16 matching lines @@
 
   // Full path to temporary file to fetch downloaded wallpper.
   const base::FilePath wallpaper_temporary_file_;
 
   // Pending retry.
   base::OneShotTimer<CustomizationWallpaperDownloader> request_scheduled_;
 
   // Number of download retries (first attempt is not counted as retry).
   size_t retries_;
 
+  // Sleep between retry requests (increasing, see Retry() method for details).
+  // Non-constant value for tests.
+  double retry_delay_seconds_;

[Daniel Erat, 2014/04/30 21:23:06]

base::TimeDelta

[Alexander Alekseev, 2014/05/04 23:30:56]

Done.

+
   // Callback supplied by caller.
   base::Callback<void(bool success, const GURL&)> on_wallpaper_fetch_completed_;
 
   base::WeakPtrFactory<CustomizationWallpaperDownloader> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CustomizationWallpaperDownloader);
 };
 
 }  //   namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_CUSTOMIZATION_WALLPAPER_DOWNLOADER_H_