Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 253833004: Add vox support for reading unnamed folder description and fix a focus bug when app launcher is ope… (Closed)

Created:
6 years, 7 months ago by jennyz
Modified:
6 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Add vox support for reading unnamed folder description. Fix a bug for SetShowState which causes the code do nothing when it is called from AppsContainerView constructor since the show_state_ is considered not changed. BUG=367370 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266794

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a commnent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M ui/app_list/views/apps_container_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/apps_container_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/folder_header_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jennyz
6 years, 7 months ago (2014-04-28 21:34:30 UTC) #1
xiyuan
https://codereview.chromium.org/253833004/diff/1/ui/app_list/views/folder_header_view.cc File ui/app_list/views/folder_header_view.cc (right): https://codereview.chromium.org/253833004/diff/1/ui/app_list/views/folder_header_view.cc#newcode129 ui/app_list/views/folder_header_view.cc:129: : base::string16(); Why use empty string when folder_name_view_->text().empty()?
6 years, 7 months ago (2014-04-28 21:43:27 UTC) #2
jennyz
https://codereview.chromium.org/253833004/diff/1/ui/app_list/views/folder_header_view.cc File ui/app_list/views/folder_header_view.cc (right): https://codereview.chromium.org/253833004/diff/1/ui/app_list/views/folder_header_view.cc#newcode129 ui/app_list/views/folder_header_view.cc:129: : base::string16(); On 2014/04/28 21:43:27, xiyuan wrote: > Why ...
6 years, 7 months ago (2014-04-28 22:23:00 UTC) #3
xiyuan
lgtm
6 years, 7 months ago (2014-04-28 22:25:27 UTC) #4
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 7 months ago (2014-04-28 22:48:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/253833004/20001
6 years, 7 months ago (2014-04-28 22:50:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:54:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 22:54:46 UTC) #8
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 7 months ago (2014-04-29 00:36:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/253833004/20001
6 years, 7 months ago (2014-04-29 00:37:42 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 09:04:53 UTC) #11
Message was sent while issue was closed.
Change committed as 266794

Powered by Google App Engine
This is Rietveld 408576698