Fix data usage tracking for domain reliability service

Fix data usage tracking for domain reliability service

Since DomainReliabilityUploader uses URLFetcher::SetURLRequestUserData()
DataUseUserData::AttachToFetcher() cannot be used. So the service is
identified separately.

BUG=655749
Committed: https://crrev.com/72f47d3e485173559958923124a4b1be9beb69f1
Cr-Commit-Position: refs/heads/master@{#436756}

[Raj, 2016-12-01 01:28:39]

rajendrant@chromium.org changed reviewers:
+ juliatuttle@chromium.org, ryansturm@chromium.org

[Raj, 2016-12-01 01:28:40]

juliatuttle: ptal components/domain_reliability/*
ryansturm: ptal components/data_use_measurement/*

[RyanSturm, 2016-12-01 01:45:20]

It might be better to make DataUseUserData::AttachToFetcher() more extensible by
changing the key and creation callback stored in URLFetcherCore into a map of
keys to creation callbacks. That seems to keep the code more consistent. WDYT?

https://codereview.chromium.org/2538313002/diff/1/components/data_use_measure...
File components/data_use_measurement/core/data_use_measurement.cc (right):

https://codereview.chromium.org/2538313002/diff/1/components/data_use_measure...
components/data_use_measurement/core/data_use_measurement.cc:96: } else if
(domain_reliability::DomainReliabilityUploader::
If domain_reliability isn't adding DataUseUserData::kUserDataKey, shouldn't
data_use_user_data be null, so this code path won't actually run?

[Julia Tuttle, 2016-12-05 19:02:29]

On 2016/12/01 01:28:40, Raj wrote:
> juliatuttle: ptal components/domain_reliability/*
> ryansturm: ptal components/data_use_measurement/*

components/domain_reliability/* lgtm

[RyanSturm, 2016-12-05 19:35:45]

If you don't want to modify AttachToFetcher, then lgtm.

[Raj, 2016-12-05 20:02:54]

On 2016/12/05 19:35:45, Ryan Sturm wrote:
> If you don't want to modify AttachToFetcher, then lgtm.

:) Thanks.
I was wondering if changing AttachToFetcher() for this usecase is worth it. I
will relook at this.
I was also thinking of similar implementation to use for codebase
(src/google_apis) that do not want to include any code from
components/data_use_measurement.
CL https://codereview.chromium.org/2486423002/

[Raj, 2016-12-06 06:00:43]

The CQ bit was checked by rajendrant@chromium.org

[commit-bot: I haz the power, 2016-12-06 06:00:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 06:08:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 06:08:15]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Raj, 2016-12-06 20:37:46]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 20:38:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:44:18]

Dry run: This issue passed the CQ dry run.

[Raj, 2016-12-06 21:53:54]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-12-06 21:53:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org, ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2538313002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-06 21:54:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 22:10:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481061234313920,
"parent_rev": "ee8e7f00a2740a998446bbb27fb559499271685d", "commit_rev":
"526d7c0f4004ea839228dfe42dc2fbadd373877f"}

[commit-bot: I haz the power, 2016-12-06 22:10:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-06 22:13:52]

Description was changed from

==========
Fix data usage tracking for domain reliability service

Since DomainReliabilityUploader uses URLFetcher::SetURLRequestUserData()
DataUseUserData::AttachToFetcher() cannot be used. So the service is
identified separately.

BUG=655749
==========

to

==========
Fix data usage tracking for domain reliability service

Since DomainReliabilityUploader uses URLFetcher::SetURLRequestUserData()
DataUseUserData::AttachToFetcher() cannot be used. So the service is
identified separately.

BUG=655749

Committed: https://crrev.com/72f47d3e485173559958923124a4b1be9beb69f1
Cr-Commit-Position: refs/heads/master@{#436756}
==========

[commit-bot: I haz the power, 2016-12-06 22:13:53]

Patchset 3 (id:??) landed as
https://crrev.com/72f47d3e485173559958923124a4b1be9beb69f1
Cr-Commit-Position: refs/heads/master@{#436756}