chrome/browser/resources/settings/people_page/fingerprint_list.html - Issue 2538303002: md-settings: Added settings for fingerprint unlock.

Side by Side Diff: chrome/browser/resources/settings/people_page/fingerprint_list.html

Issue 2538303002: md-settings: Added settings for fingerprint unlock. (Closed)

Patch Set: Nit. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.cc ('K') | « chrome/browser/resources/options_resources.grd ('k') | chrome/browser/resources/settings/people_page/fingerprint_list.js » ('j') | chrome/browser/resources/settings/people_page/fingerprint_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/cr_elements/icons.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3 <link rel="import" href="chrome://resources/html/polymer.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

	8 <link rel="import" href="/settings_shared_css.html">

	9

	10 <dom-module id="settings-fingerprint-list">

	11 <template>

	12 <style include="settings-shared">

	13 .list-item {

	14 border-bottom: 1px solid black;

	15 display: flex;

	16 }

	17

	18 .list-item[index='0'] {

	19 border-top: 1px solid black;

	20 }
	Dan Beam 2016/12/13 19:53:23 this is not the right color. we have a CSS variab this is not the right color. we have a CSS variable for this (like --settings-border or something) if you control this DOM and it'll never be weird on you, just do something like: .list-item:not([index=0]) { @apply(--settings-border-var-name-or-whatever); } you also shouldn't be putting borders on top and bottom in settings, afaik sammiequon 2016/12/13 23:33:33 The updated (but I don't think final) mocks have n Show quoted text On 2016/12/13 19:53:23, Dan Beam wrote: > this is not the right color. we have a CSS variable for this (like > --settings-border or something) > > if you control this DOM and it'll never be weird on you, just do something like: > > .list-item:not([index=0]) { > @apply(--settings-border-var-name-or-whatever); > } > > you also shouldn't be putting borders on top and bottom in settings, afaik The updated (but I don't think final) mocks have no border. I keep these tips in mind though for futures. :)
	21

	22 .warning-text {

	23 font-style: italic;

	24 }

	25 </style>

	26

	27 <div>

	28 <div>$i18n{lockScreenRegisteredFingerprints}</div>

	29 <iron-list id="fingerprintsList" items="[[fingerprints_]]">

	30 <template>

	31 <div class="list-item" index$="[[index]]">

	32 <paper-input value="{{item.name}}"></paper-input>
	Dan Beam 2016/12/13 19:53:23 why can't we just drop the {name:} stuff and just why can't we just drop the {name:} stuff and just bind directly to value="{{item}}" here and just make fingerprints_ an !Array<string>? sammiequon 2016/12/13 23:33:33 I was expecting the list to have more than just a Show quoted text On 2016/12/13 19:53:23, Dan Beam wrote: > why can't we just drop the {name:} stuff and just bind directly to > value="{{item}}" here and just make fingerprints_ an !Array<string>? I was expecting the list to have more than just a 'name' value later, but we can change that if it ever happens later. Done.
	33 <paper-icon-button icon="cr:delete" on-tap="onFingerprintDelete_">
	Dan Beam 2016/12/13 19:53:23 could this be <button is="paper-icon-button-light" could this be <button is="paper-icon-button-light"> instead? sammiequon 2016/12/13 23:33:33 Done. Show quoted text On 2016/12/13 19:53:23, Dan Beam wrote: > could this be <button is="paper-icon-button-light"> instead? Done.
	34 </paper-icon-button>

	35 </div>

	36 </template>

	37 </iron-list>

	38 <div class="settings-box first radio-indent">

	39 <paper-button is="action-link" on-tap="onAddFingerprint_"
	Dan Beam 2016/12/13 19:53:23 what is this is="action-link" doing here? what is this is="action-link" doing here? sammiequon 2016/12/13 23:33:33 Done. Show quoted text On 2016/12/13 19:53:23, Dan Beam wrote: > what is this is="action-link" doing here? Done.
	40 disabled="[[!canAddNewFingerprint_(fingerprints_.length)]]">

	41 [[getFingerprintButtonText_(fingerprints_.length)]]

	42 </paper-button>

	43 </div>

	44 <div class="warning-text">

	45 $i18n{lockScreenFingerprintWarning}

	46 </div>

	47 </div>

	48 </template>

	49 <script src="fingerprint_list.js"></script>

	50 </dom-module>

OLD	NEW