chrome/browser/resources/settings/people_page/fingerprint_list.html - Issue 2538303002: md-settings: Added settings for fingerprint unlock.

Side by Side Diff: chrome/browser/resources/settings/people_page/fingerprint_list.html

Issue 2538303002: md-settings: Added settings for fingerprint unlock. (Closed)

Patch Set: Fixed patch set 7 errors. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/browser/resources/options_resources.grd ('k') | chrome/browser/resources/settings/people_page/fingerprint_list.js » ('j') | chrome/browser/resources/settings/people_page/fingerprint_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/cr_elements/icons.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3 <link rel="import" href="chrome://resources/html/polymer.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
	stevenjb 2016/12/07 23:25:40 +paper-button +paper-button sammiequon 2016/12/08 03:50:50 Done. Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > +paper-button Done.
	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

	6 <link rel="import" href="/settings_shared_css.html">

	7

	8 <dom-module id="settings-fingerprint-list">

	9 <template>

	10 <style include="settings-shared"></style>

	11 <style>
	stevenjb 2016/12/07 23:25:40 Only one style section: <style include="settings- Only one style section: <style include="settings-shared"> page-specific-styling... </style> sammiequon 2016/12/08 03:50:50 Done. Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > Only one style section: > > <style include="settings-shared"> > page-specific-styling... > </style> Done.
	12 .list-item {

	13 border-bottom: 1px solid black;

	14 display: flex;

	15 }

	16

	17 .list-item[index='0'] {

	18 border-top: 1px solid black;

	19 }

	20

	21 .warning-text {

	22 font-style: italic;

	23 }

	24 </style>

	25

	26 <div>

	27 <div>$i18n{lockScreenRegisteredFingerprints}</div>

	28 <div>
	stevenjb 2016/12/07 23:25:40 div needed? div needed? sammiequon 2016/12/08 03:50:50 Done. Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > div needed? Done.
	29 <template is="dom-repeat" items="{{fingerprints_}}">
	stevenjb 2016/12/07 23:25:40 Does this have the expected keyboard focus behavio Does this have the expected keyboard focus behavior? You may want to use iron-list instead to get that (see other examples of iron-list and dom-repeat in Settings). sammiequon 2016/12/08 03:50:50 Yeah iron-list works a bit better with the tabbing Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > Does this have the expected keyboard focus behavior? You may want to use > iron-list instead to get that (see other examples of iron-list and dom-repeat in > Settings). Yeah iron-list works a bit better with the tabbing. Done.
	30 <div class="list-item" index$="[[index]]">

	31 <paper-input value="{{item.name}}"></paper-input>

	32 <paper-icon-button icon="cr:delete" on-tap="onFingerprintDelete_">

	33 </paper-icon-button>

	34 </div>

	35 </template>

	36 <div class="settings-box continuation radio-indent">
	stevenjb 2016/12/07 23:25:40 Use "settings-box first" since this is the first s Use "settings-box first" since this is the first settings-box. (Styling is the same as continuation). sammiequon 2016/12/08 03:50:50 Done. Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > Use "settings-box first" since this is the first settings-box. (Styling is the > same as continuation). > Done.
	37 <paper-button is="action-link" on-tap="onAddFingerprint_"

	38 disabled="[[!canAddNewFingerprint_(fingerprints_.length) ]]">
	stevenjb 2016/12/07 23:25:40 4 space indent 4 space indent sammiequon 2016/12/08 03:50:50 Done. Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > 4 space indent Done.
	39 <div hidden="[[!canAddNewFingerprint_(fingerprints_.length)]]">

	40 $i18n{lockScreenAddFingerprint}

	41 </div>

	42 <div hidden="[[canAddNewFingerprint_(fingerprints_.length)]]">

	43 [[getFingerprintButtonCannotAddText_()]]

	44 </div>

	45 </paper-button>
	stevenjb 2016/12/07 23:25:40 This is a little odd, having conditional divs insi This is a little odd, having conditional divs inside a button. Can we make the button conditional and just show formatted text when disabled instead? sammiequon 2016/12/08 03:50:50 Done. Show quoted text On 2016/12/07 23:25:40, stevenjb wrote: > This is a little odd, having conditional divs inside a button. Can we make the > button conditional and just show formatted text when disabled instead? Done.
	46 </div>

	47 </div>

	48 <div class="warning-text">

	49 $i18n{lockScreenFingerprintWarning}

	50 </div>

	51 </div>

	52 </template>

	53 <script src="fingerprint_list.js"></script>

	54 </dom-module>

OLD	NEW