chrome/browser/resources/settings/people_page/fingerprint_list.html - Issue 2538303002: md-settings: Added settings for fingerprint unlock.

Side by Side Diff: chrome/browser/resources/settings/people_page/fingerprint_list.html

Issue 2538303002: md-settings: Added settings for fingerprint unlock. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/extensions/api/settings_private/prefs_util.cc ('K') | « chrome/browser/resources/options_resources.grd ('k') | chrome/browser/resources/settings/people_page/fingerprint_list.js » ('j') | chrome/browser/resources/settings/people_page/fingerprint_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/cr_elements/icons.html">

	2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">

	3 <link rel="import" href="chrome://resources/html/polymer.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

	7 <link rel="import" href="/settings_shared_css.html">

	8

	9 <iron-iconset-svg name="fingerprint" size="24">
	jdufault 2016/12/01 17:11:19 There's a standard comment when the svg is defined There's a standard comment when the svg is defined locally explaining why. Please add it here. sammiequon 2016/12/01 20:52:29 Done. Show quoted text On 2016/12/01 17:11:19, jdufault wrote: > There's a standard comment when the svg is defined locally explaining why. > Please add it here. Done.
	10 <svg>

	11 <defs>

	12 <g id="delete">

	13 <path d="M6 19c0 1.1.9 2 2 2h8c1.1 0 2-.9 2-2V7H6v12zM19 4h-3.5l-1-1h-5l -1 1H5v2h14V4z">

	14 </g>

	15 </defs>

	16 </svg>

	17 </iron-iconset-svg>

	18

	19 <dom-module id="settings-fingerprint-list">

	20 <template>

	21 <style include="settings-shared"></style>

	22 <style>

	23 .list-item {

	24 border-bottom: 1px solid black;

	25 display: flex;
	jdufault 2016/12/01 17:11:19 I'm going to assume most of the CSS here will chan I'm going to assume most of the CSS here will change when you have finalized mocks. sammiequon 2016/12/01 20:52:29 Yes. Show quoted text On 2016/12/01 17:11:19, jdufault wrote: > I'm going to assume most of the CSS here will change when you have finalized > mocks. Yes.
	26 }

	27

	28 .list-item[index='0'] {

	29 border-top: 1px solid black;

	30 }

	31

	32 .warning-text {

	33 font-style: italic;

	34 }

	35 </style>

	36

	37 <div id="root">

	38 <div>$i18n{lockScreenRegisteredFingerprints}</div>

	39 <div id="list-area">
	jdufault 2016/12/01 17:11:19 Do you need all of these ids, "root", "list-area"? Do you need all of these ids, "root", "list-area"? sammiequon 2016/12/01 20:52:29 Nope. This were expected to be needed for the fina Show quoted text On 2016/12/01 17:11:19, jdufault wrote: > Do you need all of these ids, "root", "list-area"? Nope. This were expected to be needed for the final mocks. Removed.
	40 <template is="dom-repeat" items="{{items}}">

	41 <div class="list-item" index$="[[index]]">

	42 <paper-input value="{{item.name}}"></paper-input>

	43 <paper-icon-button icon="fingerprint:delete" on-tap="onItemDelete_">

	44 </paper-icon-button>

	45 </div>

	46 </template>

	47 <div class="settings-box continuation radio-indent">

	48 <paper-button is="action-link" on-tap="onAddFingerprint_"

	49 disabled="[[!canAddNewFingerprint_(items.length)]]">

	50 <div hidden="[[!canAddNewFingerprint_(items.length)]]">

	51 $i18n{lockScreenAddFingerprint}

	52 </div>

	53 <div hidden="[[canAddNewFingerprint_(items.length)]]">

	54 [[getFingerprintButtonCannotAddText_()]]

	55 </div>

	56 </paper-button>

	57 </div>

	58 </div>

	59 <div class="warning-text">

	60 $i18n{lockScreenFingerprintWarning}

	61 </div>

	62 </div>

	63 </template>

	64 <script src="fingerprint_list.js"></script>

	65 </dom-module>

OLD	NEW