Fix dragging snapped window to another display landing the window in the wrong bounds

Fix dragging snapped window to another display landing the window in the wrong bounds

Dragging the snapped window to another display used to restore the wrong bounds
based on still-not-updated-yet root window during the drag. This resulted in the
window landing below the shelf and almost entirely not visible.

This CL fixes the issue and adds a test.

BUG=666836
TEST=ash_unittests --gtest_filter=ToplevelWindowEventHandlerTest.DragSnappedWindowToExternalDisplay

Committed: https://crrev.com/cfb2ecbd4b3489acb4375ee9243176bd7ebd78ff
Cr-Commit-Position: refs/heads/master@{#435747}

[afakhry, 2016-12-01 01:09:56]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:10:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2016-12-01 01:11:30]

afakhry@chromium.org changed reviewers:
+ oshima@chromium.org

[afakhry, 2016-12-01 01:11:31]

Oshima-san, please take a look, thanks!

[commit-bot: I haz the power, 2016-12-01 01:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:50:35]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-12-01 18:59:43]

lgtm

https://codereview.chromium.org/2538293002/diff/1/ash/common/wm/default_state.cc
File ash/common/wm/default_state.cc (right):

https://codereview.chromium.org/2538293002/diff/1/ash/common/wm/default_state...
ash/common/wm/default_state.cc:688: // display.
would you mind adding a reference to bug?

[afakhry, 2016-12-01 20:58:03]

https://codereview.chromium.org/2538293002/diff/1/ash/common/wm/default_state.cc
File ash/common/wm/default_state.cc (right):

https://codereview.chromium.org/2538293002/diff/1/ash/common/wm/default_state...
ash/common/wm/default_state.cc:688: // display.
On 2016/12/01 18:59:43, oshima wrote:
> would you mind adding a reference to bug?

Done.

[afakhry, 2016-12-01 20:58:07]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-12-01 20:58:08]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2538293002/#ps20001
(title: "Oshima's comment")

[commit-bot: I haz the power, 2016-12-01 20:58:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:11:42]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-12-01 21:34:38]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-12-01 21:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2538293002/#ps40001
(title: "Run test only on chromeos")

[commit-bot: I haz the power, 2016-12-01 21:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:57:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-12-01 22:18:52]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-12-01 22:18:52]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2538293002/#ps60001
(title: "I just needed to rebase")

[commit-bot: I haz the power, 2016-12-01 22:19:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:50:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480630732638790,
"parent_rev": "f31a7890648172cd1c3889e6f7fc27f7529ce7e0", "commit_rev":
"62d1799c39b092c4db49a47cb581237f693875ac"}

[commit-bot: I haz the power, 2016-12-01 22:50:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-01 22:51:57]

Description was changed from

==========
Fix dragging snapped window to another display landing the window in the wrong
bounds

Dragging the snapped window to another display used to restore the wrong bounds
based on still-not-updated-yet root window during the drag. This resulted in the
window landing below the shelf and almost entirely not visible.

This CL fixes the issue and adds a test.

BUG=666836
TEST=ash_unittests
--gtest_filter=ToplevelWindowEventHandlerTest.DragSnappedWindowToExternalDisplay
==========

to

==========
Fix dragging snapped window to another display landing the window in the wrong
bounds

Dragging the snapped window to another display used to restore the wrong bounds
based on still-not-updated-yet root window during the drag. This resulted in the
window landing below the shelf and almost entirely not visible.

This CL fixes the issue and adds a test.

BUG=666836
TEST=ash_unittests
--gtest_filter=ToplevelWindowEventHandlerTest.DragSnappedWindowToExternalDisplay

Committed: https://crrev.com/cfb2ecbd4b3489acb4375ee9243176bd7ebd78ff
Cr-Commit-Position: refs/heads/master@{#435747}
==========

[commit-bot: I haz the power, 2016-12-01 22:51:58]

Patchset 4 (id:??) landed as
https://crrev.com/cfb2ecbd4b3489acb4375ee9243176bd7ebd78ff
Cr-Commit-Position: refs/heads/master@{#435747}