Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2538283002: MD Settings: Fix "Check for updates" button regression. (Closed)
Patch Set: Nit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.html
diff --git a/chrome/browser/resources/settings/about_page/about_page.html b/chrome/browser/resources/settings/about_page/about_page.html
index 0608e5c7528745d0b437c0b1b8bd884c06589ef6..d657f1c5e24bf8afee65c5941a0fd15b434c48a1 100644
--- a/chrome/browser/resources/settings/about_page/about_page.html
+++ b/chrome/browser/resources/settings/about_page/about_page.html
@@ -82,17 +82,14 @@
</div>
<div class="settings-box two-line">
<iron-icon
- hidden="[[!shouldShowUpdateStatusIcon_(
- obsoleteSystemInfo_, currentUpdateStatusEvent_)]]"
+ hidden="[[!showUpdateStatus_]]"
icon$="[[getIcon_(
obsoleteSystemInfo_, currentUpdateStatusEvent_)]]"
src="[[getIconSrc_(
obsoleteSystemInfo_, currentUpdateStatusEvent_)]]">
</iron-icon>
<div class="start">
- <div id="updateStatusMessage"
- hidden="[[!shouldShowUpdateStatusMessage_(
- obsoleteSystemInfo_, currentUpdateStatusEvent_)]]"
+ <div id="updateStatusMessage" hidden="[[!showUpdateStatus_]]"
<if expr="not chromeos">
inner-h-t-m-l="[[getUpdateStatusMessage_(
currentUpdateStatusEvent_)]]">
@@ -111,29 +108,20 @@
</span>
<div class="secondary copyable">$i18n{aboutBrowserVersion}</div>
</div>
- <span id="relaunchContainer"
-<if expr="not chromeos">
- hidden="[[!shouldShowRelaunch_(currentUpdateStatusEvent_)]]"
-</if>
-<if expr="chromeos">
- hidden="[[!shouldShowRelaunch_(
- currentUpdateStatusEvent_, targetChannel_)]]"
-</if>
- class="secondary-action">
+ <span id="buttonContainer" class="secondary-action"
+ hidden="[[!showButtonContainer_]]">
<paper-button id="relaunch" class="secondary-button"
- on-tap="onRelaunchTap_">
+ hidden="[[!showRelaunch_]]" on-tap="onRelaunchTap_">
$i18n{aboutRelaunch}
</paper-button>
<if expr="chromeos">
<paper-button id="relaunchAndPowerwash" class="secondary-button"
- hidden="[[!shouldShowRelaunchAndPowerwash_(
- currentUpdateStatusEvent_, targetChannel_)]]"
+ hidden="[[!showRelaunchAndPowerwash_]]"
on-tap="onRelaunchAndPowerwashTap_">
$i18n{aboutRelaunchAndPowerwash}
</paper-button>
<paper-button id="checkForUpdates" class="secondary-button"
- hidden="[[!shouldShowCheckUpdates_(
- currentUpdateStatusEvent_)]]"
+ hidden="[[!showCheckUpdates_]]"
on-tap="onCheckUpdatesTap_">
$i18n{aboutCheckForUpdates}
</paper-button>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698