Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 2538273002: Use a create-or-update pattern for faster local border box property updates (Closed)

Created:
3 years, 11 months ago by pdr.
Modified:
3 years, 11 months ago
Reviewers:
chrishtr, Xianzhu, trchen
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a create-or-update pattern for faster local border box property updates This patch switches to a create-or-update pattern for paint property updates of the local border box. This is a 6% improvement on large-table-collapsed-border-change-with-text [1]. [1] tools/perf/run_benchmark blink_perf.paint --browser=content-shell-release --pageset-repeat=5 --extra-browser-args=--enable-slimming-paint-v2 BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/3f4b3cca5da1170fc860d3008403c7997901f6f3 Cr-Commit-Position: refs/heads/master@{#435546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 1 chunk +17 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pdr.
3 years, 11 months ago (2016-12-01 03:32:38 UTC) #6
chrishtr
lgtm
3 years, 11 months ago (2016-12-01 03:36:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538273002/1
3 years, 11 months ago (2016-12-01 03:36:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-01 03:41:19 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2016-12-01 03:43:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f4b3cca5da1170fc860d3008403c7997901f6f3
Cr-Commit-Position: refs/heads/master@{#435546}

Powered by Google App Engine
This is Rietveld 408576698