Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/chromeos/arc/arc_service_launcher.cc

Issue 2538263005: Simplify ArcServiceManager by stop deriving it from ArcIntentHelperObserver (Closed)
Patch Set: review Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/arc_service_launcher.h" 5 #include "chrome/browser/chromeos/arc/arc_service_launcher.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 base::MakeUnique<ArcContentFileSystemService>(arc_bridge_service)); 95 base::MakeUnique<ArcContentFileSystemService>(arc_bridge_service));
96 arc_service_manager_->AddService(base::MakeUnique<ArcCrashCollectorBridge>( 96 arc_service_manager_->AddService(base::MakeUnique<ArcCrashCollectorBridge>(
97 arc_bridge_service, arc_service_manager_->blocking_task_runner())); 97 arc_bridge_service, arc_service_manager_->blocking_task_runner()));
98 arc_service_manager_->AddService( 98 arc_service_manager_->AddService(
99 base::MakeUnique<ArcDownloadsWatcherService>(arc_bridge_service)); 99 base::MakeUnique<ArcDownloadsWatcherService>(arc_bridge_service));
100 arc_service_manager_->AddService( 100 arc_service_manager_->AddService(
101 base::MakeUnique<ArcEnterpriseReportingService>(arc_bridge_service)); 101 base::MakeUnique<ArcEnterpriseReportingService>(arc_bridge_service));
102 auto intent_helper = base::MakeUnique<ArcIntentHelperBridge>( 102 auto intent_helper = base::MakeUnique<ArcIntentHelperBridge>(
103 arc_bridge_service, arc_service_manager_->icon_loader(), 103 arc_bridge_service, arc_service_manager_->icon_loader(),
104 arc_service_manager_->activity_resolver()); 104 arc_service_manager_->activity_resolver());
105 // We don't have to remove observer since 105 // We don't have to call ArcIntentHelperBridge::RemoveObserver() in
106 // ArcServiceManager always outlives ArcIntentHelperBridge. 106 // ~ArcServiceManager() since the observer in ArcServiceManager always
107 intent_helper->AddObserver(arc_service_manager_.get()); 107 // outlives the ArcIntentHelperBridge object.
108 intent_helper->AddObserver(arc_service_manager_->intent_helper_observer());
108 arc_service_manager_->AddService(std::move(intent_helper)); 109 arc_service_manager_->AddService(std::move(intent_helper));
109 arc_service_manager_->AddService( 110 arc_service_manager_->AddService(
110 base::MakeUnique<ArcImeService>(arc_bridge_service)); 111 base::MakeUnique<ArcImeService>(arc_bridge_service));
111 arc_service_manager_->AddService( 112 arc_service_manager_->AddService(
112 base::MakeUnique<ArcKioskBridge>(arc_bridge_service)); 113 base::MakeUnique<ArcKioskBridge>(arc_bridge_service));
113 arc_service_manager_->AddService( 114 arc_service_manager_->AddService(
114 base::MakeUnique<ArcMetricsService>(arc_bridge_service)); 115 base::MakeUnique<ArcMetricsService>(arc_bridge_service));
115 arc_service_manager_->AddService( 116 arc_service_manager_->AddService(
116 base::MakeUnique<ArcNetHostImpl>(arc_bridge_service)); 117 base::MakeUnique<ArcNetHostImpl>(arc_bridge_service));
117 arc_service_manager_->AddService( 118 arc_service_manager_->AddService(
(...skipping 28 matching lines...) Expand all
146 147
147 void ArcServiceLauncher::Shutdown() { 148 void ArcServiceLauncher::Shutdown() {
148 DCHECK(arc_service_manager_); 149 DCHECK(arc_service_manager_);
149 // Destroy in the reverse order of the initialization. 150 // Destroy in the reverse order of the initialization.
150 arc_service_manager_->Shutdown(); 151 arc_service_manager_->Shutdown();
151 arc_session_manager_.reset(); 152 arc_session_manager_.reset();
152 arc_service_manager_.reset(); 153 arc_service_manager_.reset();
153 } 154 }
154 155
155 } // namespace arc 156 } // namespace arc
OLDNEW
« no previous file with comments | « no previous file | components/arc/arc_service_manager.h » ('j') | components/arc/arc_service_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698