Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2538233005: dart2js-kernel: Fix code for JS_SET_STATIC_STATE (Closed)
Patch Set: remove debug print Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder_kernel.dart
diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart
index ce1a9da189aea13dddd1efeafa379e64e883c6d8..e940248299e9b57c4d7772ddddbab3d6f9065601 100644
--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart
+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart
@@ -1297,16 +1297,18 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {
}
void handleForeignJsSetStaticState(ir.StaticInvocation invocation) {
- if (_unexpectedForeignArguments(invocation, 0, 0)) {
+ if (_unexpectedForeignArguments(invocation, 1, 1)) {
stack.add(graph.addConstantNull(compiler)); // Result expected on stack.
return;
}
- _visitArguments(invocation.arguments);
+
+ List<HInstruction> inputs = _visitArguments(invocation.arguments);
+
String isolateName = backend.namer.staticStateHolder;
SideEffects sideEffects = new SideEffects.empty();
sideEffects.setAllSideEffects();
push(new HForeignCode(js.js.parseForeignJS("$isolateName = #"),
- backend.dynamicType, <HInstruction>[pop()],
+ backend.dynamicType, inputs,
nativeBehavior: native.NativeBehavior.CHANGES_OTHER,
effects: sideEffects));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698