chrome/chrome.gyp - Issue 253823005: DevTools: extract DevToolsWindowBase, leave docking, unload and factory logic in DevToolsWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.gyp

Issue 253823005: DevTools: extract DevToolsWindowBase, leave docking, unload and factory logic in DevToolsWindow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review comments addressed. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome.gyp

diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp

index 646ca47dae1e221f2a7db425c110f0b8702411fe..972ed8d5b31ee8ba3469a876646be22bc9409d65 100644

--- a/chrome/chrome.gyp

+++ b/chrome/chrome.gyp

@@ -186,6 +186,8 @@

'browser/devtools/devtools_toggle_action.h',

'browser/devtools/devtools_window.cc',

'browser/devtools/devtools_window.h',

+ 'browser/devtools/devtools_window_base.cc',

+ 'browser/devtools/devtools_window_base.h',

'browser/devtools/remote_debugging_server.cc',

'browser/devtools/remote_debugging_server.h',

@@ -200,6 +202,7 @@

'browser/devtools/devtools_file_system_indexer.cc',

'browser/devtools/devtools_target_impl.cc',

'browser/devtools/devtools_window.cc',

+ 'browser/devtools/devtools_window_base.cc',

'browser/devtools/remote_debugging_server.cc',

}],

« chrome/browser/devtools/devtools_window.cc ('K') | « chrome/browser/devtools/devtools_window_base.cc ('k') | no next file » | no next file with comments »