Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 253823003: Expose useThreadedParserForDataUrls temporarily (Closed)

Created:
6 years, 7 months ago by eseidel
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, dcheng, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Expose useThreadedParserForDataUrls temporarily Exposing this to Chromium and having Chromium set it to false when running browser_tests will make the transition easier. I attempted to delete this setting last week and at the same time flip its value from false to true. Unfortunately many browser_tests depend on data urls being sync, despite the web at large not depending on that behavior (since both IE and FF parse data urls async). It's silly to expose this to chromium just to delete it a few days later but unfortunately it's difficult to test blink changes through the chromium try bots so making it possible for Chromium to control this setting will make it much easier to test chromium-side fixes to browser_tests in preparation for later removing this setting and making data urls always async. BUG=308321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eseidel
6 years, 7 months ago (2014-04-29 01:35:46 UTC) #1
abarth-chromium
> Unfortunately many browser_tests depend on data urls being async sync
6 years, 7 months ago (2014-04-29 18:18:34 UTC) #2
abarth-chromium
lgtm
6 years, 7 months ago (2014-04-29 18:18:57 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 7 months ago (2014-04-29 18:27:34 UTC) #4
eseidel
The CQ bit was unchecked by eseidel@chromium.org
6 years, 7 months ago (2014-04-29 18:27:54 UTC) #5
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 7 months ago (2014-04-29 18:27:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/253823003/1
6 years, 7 months ago (2014-04-29 18:28:14 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 04:31:12 UTC) #8
Message was sent while issue was closed.
Change committed as 172921

Powered by Google App Engine
This is Rietveld 408576698