Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2538213003: [Merge to M56] Fix View Frame Source for iframe of a file:// URL shows main frame's filename (Closed)

Created:
4 years ago by afakhry
Modified:
4 years ago
Reviewers:
Charlie Reis, sky
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge to M56] Fix View Frame Source for iframe of a file:// URL shows main frame's filename View Frame Source for iframe of a file:// URL used to show the main frame's filename instead of the expected title derived from the iframe's page URL in the form of "view-source:url". This CL fixes this and adds a browser test. TBR=creis@chromium.org,sky@chromium.org BUG=659040 TEST=browser_tests --gtest_filter=ChromeNavigationBrowserTest.TestViewFrameSource Review-Url: https://codereview.chromium.org/2501083004 Cr-Commit-Position: refs/heads/master@{#435021} (cherry picked from commit 4d116bd4f43359ce057a60c82c2188c93d49a638) Committed: https://chromium.googlesource.com/chromium/src/+/e13c83eaae5c04aecfb3a7b75921be2b20b07a67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M chrome/browser/chrome_navigation_browsertest.cc View 2 chunks +51 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/filters/site-per-process.browser_tests.filter View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
afakhry
4 years ago (2016-12-01 02:16:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
e13c83eaae5c04aecfb3a7b75921be2b20b07a67 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698