Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: logdog/api/endpoints/coordinator/logs/v1/logs.proto

Issue 2538203002: LogDog: Add signed GS URL fetching. (Closed)
Patch Set: Allow index signing, use gaesigner. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | logdog/api/endpoints/coordinator/logs/v1/logs.pb.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/api/endpoints/coordinator/logs/v1/logs.proto
diff --git a/logdog/api/endpoints/coordinator/logs/v1/logs.proto b/logdog/api/endpoints/coordinator/logs/v1/logs.proto
index 32a13e7620b779dc0079c0ba52626fa5b2fdda12..5b8e8d8f6e7809b45e17f2f7f1fe748d99151ae6 100644
--- a/logdog/api/endpoints/coordinator/logs/v1/logs.proto
+++ b/logdog/api/endpoints/coordinator/logs/v1/logs.proto
@@ -9,6 +9,7 @@ package logdog;
import "github.com/luci/luci-go/logdog/api/endpoints/coordinator/logs/v1/state.proto";
import "github.com/luci/luci-go/logdog/api/logpb/log.proto";
import "google/protobuf/timestamp.proto";
+import "google/protobuf/duration.proto";
// GetRequest is the request structure for the user Get endpoint.
//
@@ -64,6 +65,20 @@ message GetRequest {
// A contiguous request with Index 3 will return: [3, 4], stopping because
// 5 is missing. A non-contiguous request will return [3, 4, 6, 7].
bool non_contiguous = 7;
+
+ // If supplied, the response will contain a SignedUrls message with the
+ // requested signed URLs. If signed URLs are not supported by the log's
+ // current storage system, the response message will be empty.
+ message SignURLRequest {
+ // The lifetime that the signed URL will be bound to.. The
+ google.protobuf.Duration lifetime = 1;
+
+ // Return a signed URL for the log's RecordIO protobuf data.
+ bool stream = 2;
+ // Return a signed URL for the log's LogIndex protobuf.
+ bool index = 3;
+ }
+ SignURLRequest get_signed_urls = 8;
}
// TailRequest is the request structure for the user Tail endpoint. It returns
@@ -106,6 +121,20 @@ message GetResponse {
// Log represents the set of retrieved log records.
repeated logpb.LogEntry logs = 4;
+
+ // Holds information about the log stream's signed entry URL.
+ message SignedUrls {
+ // The time when this signed URL will expire.
+ google.protobuf.Timestamp expiration = 1;
+
+ // The signed log stream URL, if requested.
+ string stream = 2;
+ // The signed log index URL, if requested.
+ string index = 3;
+ }
+ // An optional signed log entry RecordIO protobuf URL, if requested via
+ // "sign_entry_url_lifetime".
Vadim Sh. 2016/12/01 19:32:13 "sign_entry_url_lifetime" is no longer defined
+ SignedUrls signed_urls = 5;
}
// QueryRequest is the request structure for the user Query endpoint.
« no previous file with comments | « no previous file | logdog/api/endpoints/coordinator/logs/v1/logs.pb.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698