Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects.

Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (patchset #14 id:260001 of https://codereview.chromium.org/2471883003/ )

Reason for revert:
Probably causes bot failures (see https://bugs.chromium.org/p/v8/issues/detail?id=5707).

TBR=mtrofin@chromium.org

Original issue's description:
> [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects.
> 
> Add support for WebAssembly.Memory objects to be simultaneously referenced by multiple Instance objects. GrowingMemory should maintain a consistent view of memory across instances.
>  - Store a link to instances that share WebAssembly.Memory in the WasmMemoryObject, updated on instantiate.
>  - Implement WasmInstanceWrapper as a wrapper around the instance object to keep track of previous/next instances, instance object is stored as a WeakCell that can be garbage collected.
>  - MemoryInstanceFinalizer maintains a valid list of instances when an instance is garbage collected.
>  - Refactor GrowInstanceMemory to GrowMemoryBuffer that allocates a new buffer, and UncheckedUpdateInstanceMemory that updates memory references for an instance.
> 
>  R=titzer@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org
> 
> Committed: https://crrev.com/30ef8e33f3a199a27ca8512bcee314c9522d03f6
> Committed: https://crrev.com/3c98e339599b068f1ed630afb7601ff942424d31
> Committed: https://crrev.com/e108f90d5c17588910f1f91c56ceba2580277000
> Cr-Original-Original-Commit-Position: refs/heads/master@{#41121}
> Cr-Original-Commit-Position: refs/heads/master@{#41198}
> Cr-Commit-Position: refs/heads/master@{#41234}

TBR=bradnelson@chromium.org,mtrofin@chromium.org,titzer@chromium.org,ahaas@chromium.org,gdeepti@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

[petermarshall, 2016-12-01 15:21:00]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2016-12-01 15:21:01]

Created Revert of [wasm] WebAssembly.Memory object can be referenced by multiple
Instance objects.

[commit-bot: I haz the power, 2016-12-01 15:21:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 15:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:21:15]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[petermarshall, 2016-12-01 15:27:26]

The CQ bit was checked by petermarshall@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 15:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:27:34]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[petermarshall, 2016-12-01 15:31:08]

Description was changed from

==========
Revert of [wasm] WebAssembly.Memory object can be referenced by multiple
Instance objects. (patchset #14 id:260001 of
https://codereview.chromium.org/2471883003/ )

Reason for revert:
Probably causes bot failures (see
https://bugs.chromium.org/p/v8/issues/detail?id=5707).

Original issue's description:
> [wasm] WebAssembly.Memory object can be referenced by multiple Instance
objects.
> 
> Add support for WebAssembly.Memory objects to be simultaneously referenced by
multiple Instance objects. GrowingMemory should maintain a consistent view of
memory across instances.
>  - Store a link to instances that share WebAssembly.Memory in the
WasmMemoryObject, updated on instantiate.
>  - Implement WasmInstanceWrapper as a wrapper around the instance object to
keep track of previous/next instances, instance object is stored as a WeakCell
that can be garbage collected.
>  - MemoryInstanceFinalizer maintains a valid list of instances when an
instance is garbage collected.
>  - Refactor GrowInstanceMemory to GrowMemoryBuffer that allocates a new
buffer, and UncheckedUpdateInstanceMemory that updates memory references for an
instance.
> 
>  R=titzer@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org
> 
> Committed: https://crrev.com/30ef8e33f3a199a27ca8512bcee314c9522d03f6
> Committed: https://crrev.com/3c98e339599b068f1ed630afb7601ff942424d31
> Committed: https://crrev.com/e108f90d5c17588910f1f91c56ceba2580277000
> Cr-Original-Original-Commit-Position: refs/heads/master@{#41121}
> Cr-Original-Commit-Position: refs/heads/master@{#41198}
> Cr-Commit-Position: refs/heads/master@{#41234}

TBR=bradnelson@chromium.org,mtrofin@chromium.org,titzer@chromium.org,ahaas@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of [wasm] WebAssembly.Memory object can be referenced by multiple
Instance objects. (patchset #14 id:260001 of
https://codereview.chromium.org/2471883003/ )

Reason for revert:
Probably causes bot failures (see
https://bugs.chromium.org/p/v8/issues/detail?id=5707).

TBR=mtrofin@chromium.org

Original issue's description:
> [wasm] WebAssembly.Memory object can be referenced by multiple Instance
objects.
> 
> Add support for WebAssembly.Memory objects to be simultaneously referenced by
multiple Instance objects. GrowingMemory should maintain a consistent view of
memory across instances.
>  - Store a link to instances that share WebAssembly.Memory in the
WasmMemoryObject, updated on instantiate.
>  - Implement WasmInstanceWrapper as a wrapper around the instance object to
keep track of previous/next instances, instance object is stored as a WeakCell
that can be garbage collected.
>  - MemoryInstanceFinalizer maintains a valid list of instances when an
instance is garbage collected.
>  - Refactor GrowInstanceMemory to GrowMemoryBuffer that allocates a new
buffer, and UncheckedUpdateInstanceMemory that updates memory references for an
instance.
> 
>  R=titzer@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org
> 
> Committed: https://crrev.com/30ef8e33f3a199a27ca8512bcee314c9522d03f6
> Committed: https://crrev.com/3c98e339599b068f1ed630afb7601ff942424d31
> Committed: https://crrev.com/e108f90d5c17588910f1f91c56ceba2580277000
> Cr-Original-Original-Commit-Position: refs/heads/master@{#41121}
> Cr-Original-Commit-Position: refs/heads/master@{#41198}
> Cr-Commit-Position: refs/heads/master@{#41234}

TBR=bradnelson@chromium.org,mtrofin@chromium.org,titzer@chromium.org,ahaas@ch...
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

[petermarshall, 2016-12-01 15:31:25]

The CQ bit was checked by petermarshall@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 15:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:31:34]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Michael Hablich, 2016-12-01 15:39:45]

On 2016/12/01 15:31:34, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> Committers are members of the group "project-v8-committers".
> Note that this has nothing to do with OWNERS files.

lgtm

[Michael Hablich, 2016-12-01 15:39:49]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:39:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 15:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:41:24]

Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17172)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17139)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29791)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18864)

[titzer, 2017-01-09 09:08:14]

On 2016/12/01 15:41:24, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17172)
>   v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
>   v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17139)
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29791)
>   v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18864)

Is this CL now obsolete?

[petermarshall, 2017-01-09 09:09:13]

On 2017/01/09 at 09:08:14, titzer wrote:
> On 2016/12/01 15:41:24, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17172)
> >   v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
> >   v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17139)
> >   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29791)
> >   v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/18864)
> 
> Is this CL now obsolete?

Yeah I'll get rid of it.