[NaCl SDK] Implement FakePepperInterfaceGoogleDriveFs

native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_url_loader.cc

Index: native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_url_loader.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_url_loader.cc b/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_url_loader.cc
index 1df756d4f5f93b9a3b97457c299eca67b05834e8..1f4df3f2e7b0fa17e33b0ed5fd27b14d157dec84 100644
--- a/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_url_loader.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_url_loader.cc
@@ -13,6 +13,7 @@
 
 #include "fake_ppapi/fake_util.h"
 #include "nacl_io/osinttypes.h"
+#include "ppapi/c/pp_bool.h"

[chanpatorikku, 2016/12/02 13:23:33]

Almost always the ppapi/c/*.* isincluded as "<..>", not "..".

"<..>" is probably the include style and ought to be switched from ".." in the
next patch set.

[binji, 2016/12/02 22:30:39]

Yes, for consistency this should be moved after "gtest/gtest.h" and before
"fake_ppapi/fake_util.h" and use <..>

[chanpatorikku, 2016/12/05 15:05:44]

Done.

 
 namespace {
 
@@ -470,6 +471,14 @@ PP_Bool FakeURLRequestInfoInterface::SetProperty(PP_Resource request,
       // Throw the value away for now. TODO(binji): add tests for this.
       return PP_TRUE;
     }
+    case PP_URLREQUESTPROPERTY_STREAMTOFILE: {
+      if (value.type != PP_VARTYPE_BOOL)
+        return PP_FALSE;
+
+      // TODO: add tests for this.

[binji, 2016/12/02 22:30:38]

not necessary, the comments above are because the value isn't used. The value is
used here.

[chanpatorikku, 2016/12/05 15:05:44]

Done.

+      request_resource->stream_to_file = PP_ToBool(value.value.as_bool);
+      return PP_TRUE;
+    }
     default:
       EXPECT_TRUE(false) << "Unimplemented property " << property
                          << " in "