Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2538143003: Issue 27903. Use shared logic for computing new method location. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -58 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +11 lines, -25 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 17 chunks +35 lines, -33 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-11-30 18:14:39 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2538143003/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart File pkg/analysis_server/test/services/correction/fix_test.dart (right): https://codereview.chromium.org/2538143003/diff/1/pkg/analysis_server/test/services/correction/fix_test.dart#newcode4604 pkg/analysis_server/test/services/correction/fix_test.dart:4604: void process(Map items) {} It would be good ...
4 years ago (2016-11-30 18:22:58 UTC) #2
scheglov
4 years ago (2016-11-30 20:15:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
666d4efce2c8b110aabe44139151e5e0581d9576 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698