Add sync settings for reading list

Add sync settings for reading list

Add the data type for the reading list sync settings.

BUG=669393
Committed: https://crrev.com/8b6ee85841b4b129886caa10c9652921e8df703b
Cr-Commit-Position: refs/heads/master@{#435311}

[gambard, 2016-11-30 14:01:15]

gambard@chromium.org changed reviewers:
+ maxbogue@chromium.org, olivierrobin@chromium.org

[gambard, 2016-11-30 14:01:16]

PTAL.

[Olivier, 2016-11-30 14:10:26]

https://codereview.chromium.org/2538143002/diff/1/components/sync_ui_strings....
File components/sync_ui_strings.grdp (right):

https://codereview.chromium.org/2538143002/diff/1/components/sync_ui_strings....
components/sync_ui_strings.grdp:28: <message
name="IDS_SYNC_DATATYPE_READING_LIST" desc="Reading List, one of the data types
that we allow syncing">
Is this used somewhere?

[gambard, 2016-11-30 14:31:44]

https://codereview.chromium.org/2538143002/diff/1/components/sync_ui_strings....
File components/sync_ui_strings.grdp (right):

https://codereview.chromium.org/2538143002/diff/1/components/sync_ui_strings....
components/sync_ui_strings.grdp:28: <message
name="IDS_SYNC_DATATYPE_READING_LIST" desc="Reading List, one of the data types
that we allow syncing">
On 2016/11/30 14:10:26, Olivier Robin wrote:
> Is this used somewhere?

It is used in the UI, downstream.

[Olivier, 2016-11-30 14:33:10]

lgtm

[maxbogue, 2016-11-30 17:09:57]

lgtm

[gambard, 2016-11-30 17:10:16]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2016-11-30 17:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 17:25:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480525816340170, "parent_rev":
"2d98e8842fae941157624ba7000fd896c25c9595", "commit_rev":
"973d06e1f4d65eec8ef88a55e195e68b18e537bc"}

[commit-bot: I haz the power, 2016-11-30 17:26:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-30 17:28:53]

Description was changed from

==========
Add sync settings for reading list

Add the data type for the reading list sync settings.

BUG=669393
==========

to

==========
Add sync settings for reading list

Add the data type for the reading list sync settings.

BUG=669393

Committed: https://crrev.com/8b6ee85841b4b129886caa10c9652921e8df703b
Cr-Commit-Position: refs/heads/master@{#435311}
==========

[commit-bot: I haz the power, 2016-11-30 17:28:54]

Patchset 1 (id:??) landed as
https://crrev.com/8b6ee85841b4b129886caa10c9652921e8df703b
Cr-Commit-Position: refs/heads/master@{#435311}