Issue 253813003: Fix uninit member variable of TouchEventQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 253813003: Fix uninit member variable of TouchEventQueue (Closed)

Created:
6 years, 7 months ago by jdduke (slow)

Modified:
6 years, 7 months ago

Reviewers:
tdresser, Rick Byers

CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix uninit member variable of TouchEventQueue The variable |needs_async_touch_move_for_outer_slop_region_| was not being initialized upon TouchEventQueue construction. Initialize accordingly. Note that while the read was invalid, it had no meaningful effect on touch dispatch behavior, as the variable was *always* reset before it could impact touch forwarding. BUG=367692

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	content/browser/renderer_host/input/touch_event_queue.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	content/browser/renderer_host/input/touch_event_queue.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/253813003/1

6 years, 7 months ago (2014-04-28 15:26:47 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 7 months ago (2014-04-28 15:53:54 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on android_dbg

6 years, 7 months ago (2014-04-28 15:53:55 UTC) #7

The CQ bit was unchecked by jdduke@chromium.org

Expand Messages | Collapse Messages