Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2538113005: mash: Move session_types.h to ash/public (Closed)

Created:
4 years ago by xiyuan
Modified:
4 years ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, jam, sadrul, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move session_types.h to ash/public So that it can be used for mojo type mapping. BUG=648964 Committed: https://crrev.com/40d5f69b8e4a5454f0b4e0f84499941661c5430f Cr-Commit-Position: refs/heads/master@{#435709}

Patch Set 1 #

Patch Set 2 : fix gn deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -37 lines) Patch
M ash/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/common/media_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/session/session_state_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
D ash/common/session/session_types.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/common/system/user/tray_user.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/user/user_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/content/shell_content_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ash/public/cpp/session_types.h View 2 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
xiyuan
4 years ago (2016-12-01 19:24:44 UTC) #8
James Cook
LGTM
4 years ago (2016-12-01 20:36:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538113005/20001
4 years ago (2016-12-01 20:54:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 21:01:33 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 21:04:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40d5f69b8e4a5454f0b4e0f84499941661c5430f
Cr-Commit-Position: refs/heads/master@{#435709}

Powered by Google App Engine
This is Rietveld 408576698