Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2538103002: Add ubsan_no_recover_hack to missing ubsan builders. (Closed)

Created:
4 years ago by mmoroz
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ubsan_no_recover_hack to missing ubsan builders. R=inferno@chromium.org, ochang@chromium.org, phajdan.jr@chromium.org BUG=669566 Committed: https://crrev.com/a50c295543d07efaedd8534d117f3860a3df52e8 Cr-Commit-Position: refs/heads/master@{#435317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mmoroz
4 years ago (2016-11-30 11:05:13 UTC) #1
Paweł Hajdan Jr.
LGTM
4 years ago (2016-11-30 12:12:59 UTC) #2
inferno
lgtm, but we need the expectations file updates ?
4 years ago (2016-11-30 16:06:00 UTC) #3
mmoroz
On 2016/11/30 16:06:00, inferno wrote: > lgtm, but we need the expectations file updates ? ...
4 years ago (2016-11-30 16:11:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538103002/1
4 years ago (2016-11-30 16:21:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 17:36:07 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a50c295543d07efaedd8534d117f3860a3df52e8 Cr-Commit-Position: refs/heads/master@{#435317}
4 years ago (2016-11-30 17:39:03 UTC) #10
inferno
4 years ago (2016-12-13 04:48:10 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2568883003/ by inferno@chromium.org.

The reason for reverting is: UBSan is noisy and can't be enabled for explicit
crash behavior on builders. On ClusterFuzz, it will be still enabled to create
testcases.

BUG=673488.

Powered by Google App Engine
This is Rietveld 408576698