Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h

Issue 2538053002: Barcode/Face detection: reject requests in platforms where not implemented (Closed)
Patch Set: reillyg@s comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
diff --git a/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h b/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
index 20883f7396230754ea03f4b1288400889bc3bc7b..744007a8d8427dc3bf74b48b16217f40e533d5a3 100644
--- a/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
+++ b/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.h
@@ -57,10 +57,15 @@ class MODULES_EXPORT ShapeDetector
void onDetectBarcodes(ScriptPromiseResolver*,
Vector<mojom::blink::BarcodeDetectionResultPtr>);
+ // Error handlers for use if mojo service doesn't connect.
+ void onFaceServiceConnectionError();
+ void onBarcodeServiceConnectionError();
+
mojom::blink::FaceDetectionPtr m_faceService;
mojom::blink::BarcodeDetectionPtr m_barcodeService;
- HeapHashSet<Member<ScriptPromiseResolver>> m_serviceRequests;
+ HeapHashSet<Member<ScriptPromiseResolver>> m_faceServiceRequests;
+ HeapHashSet<Member<ScriptPromiseResolver>> m_barcodeServiceRequests;
protected:
mojom::blink::FaceDetectorOptionsPtr m_faceDetectorOptions;

Powered by Google App Engine
This is Rietveld 408576698