Settings: About: Fix cros channel info.

chrome/browser/resources/settings/about_page/detailed_build_info.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-detailed-build-info' contains detailed build
  * information for ChromeOS.
  */
 
 Polymer({
   is: 'settings-detailed-build-info',
 
   behaviors: [I18nBehavior],
 
   properties: {
     /** @private {!VersionInfo} */
     versionInfo_: Object,
 
     /** @private */
     currentlyOnChannelText_: String,
 
     /** @private */
     showChannelSwitcherDialog_: Boolean,
 
     /** @private */
-    canChangeChannel_: {
-      type: Boolean,
-      value: function() {
-        return loadTimeData.getBoolean('aboutCanChangeChannel');
-      },
-    },
+    canChangeChannel_: Boolean,
   },
 
   /** @override */
   ready: function() {
     var browserProxy = settings.AboutPageBrowserProxyImpl.getInstance();
     browserProxy.pageReady();
 
     browserProxy.getVersionInfo().then(function(versionInfo) {
       this.versionInfo_ = versionInfo;
     }.bind(this));
-    browserProxy.getCurrentChannel().then(function(channel) {
+
+    this.getChannel();

[dpapad, 2016/12/05 18:52:27]

It took me a second to realize that |getChannel| actually updates the state of
|this|. Can you rename to |updateChannel| instead?

[stevenjb, 2016/12/06 20:38:02]

Done.

+
+    browserProxy.getCanChangeChannel().then(function(canChangeChannel) {
+      this.canChangeChannel_ = canChangeChannel;
+    }.bind(this));
+  },
+
+  /** @private */
+  getChannel: function() {

[dpapad, 2016/12/05 18:52:27]

Private methods should end with "_" suffix.

[stevenjb, 2016/12/06 20:38:02]

Done.

+    var browserProxy = settings.AboutPageBrowserProxyImpl.getInstance();
+    // We actually display the target channel for the 'Currently on' message.

[dpapad, 2016/12/05 18:52:27]

Nit: s/We actually d/D/

[stevenjb, 2016/12/06 20:38:02]

Done.

+    browserProxy.getTargetChannel().then(function(channel) {
       this.currentlyOnChannelText_ = this.i18n(
           'aboutCurrentlyOnChannel',
           this.i18n(settings.browserChannelToI18nId(channel)));
     }.bind(this));
   },
 
   /**
    * @param {string} version
    * @return {boolean}
    * @private
    */
   shouldShowVersion_: function(version) {
     return version.length > 0;
   },
 
   /** @private */
   onChangeChannelTap_: function() {
     this.showChannelSwitcherDialog_ = true;
     // Async to wait for dialog to appear in the DOM.
     this.async(function() {
       var dialog = this.$$('settings-channel-switcher-dialog');
       // Register listener to detect when the dialog is closed. Flip the boolean
       // once closed to force a restamp next time it is shown such that the
       // previous dialog's contents are cleared.
       dialog.addEventListener('close', function() {
         this.showChannelSwitcherDialog_ = false;
+        this.getChannel();
       }.bind(this));
     }.bind(this));
   },
 });