Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/ui/webui/settings/about_handler.h

Issue 2538043006: Settings: About: Fix cros channel info. (Closed)
Patch Set: Fix non cros tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_ABOUT_HANDLER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SETTINGS_ABOUT_HANDLER_H_
6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_ABOUT_HANDLER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SETTINGS_ABOUT_HANDLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 // Opens the feedback dialog. |args| must be empty. 84 // Opens the feedback dialog. |args| must be empty.
85 void HandleOpenFeedbackDialog(const base::ListValue* args); 85 void HandleOpenFeedbackDialog(const base::ListValue* args);
86 86
87 // Opens the help page. |args| must be empty. 87 // Opens the help page. |args| must be empty.
88 void HandleOpenHelpPage(const base::ListValue* args); 88 void HandleOpenHelpPage(const base::ListValue* args);
89 89
90 #if defined(OS_CHROMEOS) 90 #if defined(OS_CHROMEOS)
91 // Sets the release track version. 91 // Sets the release track version.
92 void HandleSetChannel(const base::ListValue* args); 92 void HandleSetChannel(const base::ListValue* args);
93 93
94 // Checks for and applies update, triggered by JS.
95 void HandleRequestUpdate(const base::ListValue* args);
96
97 // Retrieves OS, ARC and firmware versions. 94 // Retrieves OS, ARC and firmware versions.
98 void HandleGetVersionInfo(const base::ListValue* args); 95 void HandleGetVersionInfo(const base::ListValue* args);
99 void OnGetVersionInfoReady( 96 void OnGetVersionInfoReady(
100 std::string callback_id, 97 std::string callback_id,
101 std::unique_ptr<base::DictionaryValue> version_info); 98 std::unique_ptr<base::DictionaryValue> version_info);
102 99
103 void HandleGetCurrentChannel(const base::ListValue* args); 100 // Retrieves combined channel info.
104 void HandleGetTargetChannel(const base::ListValue* args); 101 void HandleGetChannelInfo(const base::ListValue* args);
105 // C++ callback for either of |HandleGetCurrentChannel| or 102 // Callbacks for version_updater_->GetChannel calls.
106 // |HandleGetTargetChannel|, 103 void OnGetCurrentChannel(std::string callback_id,
107 void OnGetChannelReady(std::string callback_id, const std::string& channel); 104 const std::string& current_channel);
105 void OnGetTargetChannel(std::string callback_id,
106 const std::string& current_channel,
107 const std::string& target_channel);
108
109 // Checks for and applies update, triggered by JS.
110 void HandleRequestUpdate(const base::ListValue* args);
111
108 #endif 112 #endif
109 113
110 // Checks for and applies update. 114 // Checks for and applies update.
111 void RequestUpdate(); 115 void RequestUpdate();
112 116
113 // Callback method which forwards status updates to the page. 117 // Callback method which forwards status updates to the page.
114 void SetUpdateStatus(VersionUpdater::Status status, 118 void SetUpdateStatus(VersionUpdater::Status status,
115 int progress, 119 int progress,
116 const base::string16& fail_message); 120 const base::string16& fail_message);
117 121
(...skipping 27 matching lines...) Expand all
145 149
146 // Used for callbacks. 150 // Used for callbacks.
147 base::WeakPtrFactory<AboutHandler> weak_factory_; 151 base::WeakPtrFactory<AboutHandler> weak_factory_;
148 152
149 DISALLOW_COPY_AND_ASSIGN(AboutHandler); 153 DISALLOW_COPY_AND_ASSIGN(AboutHandler);
150 }; 154 };
151 155
152 } // namespace settings 156 } // namespace settings
153 157
154 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_ABOUT_HANDLER_H_ 158 #endif // CHROME_BROWSER_UI_WEBUI_SETTINGS_ABOUT_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/about_page/detailed_build_info.js ('k') | chrome/browser/ui/webui/settings/about_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698