Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2538043006: Settings: About: Fix cros channel info. (Closed)
Patch Set: Fix non cros tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page_browser_proxy.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-about-page', 10 is: 'settings-about-page',
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 'updateShowUpdateStatus_(' + 76 'updateShowUpdateStatus_(' +
77 'obsoleteSystemInfo_, currentUpdateStatusEvent_)', 77 'obsoleteSystemInfo_, currentUpdateStatusEvent_)',
78 'updateShowRelaunch_(currentUpdateStatusEvent_)', 78 'updateShowRelaunch_(currentUpdateStatusEvent_)',
79 'updateShowButtonContainer_(showRelaunch_)', 79 'updateShowButtonContainer_(showRelaunch_)',
80 </if> 80 </if>
81 81
82 <if expr="chromeos"> 82 <if expr="chromeos">
83 'updateShowUpdateStatus_(' + 83 'updateShowUpdateStatus_(' +
84 'obsoleteSystemInfo_, currentUpdateStatusEvent_,' + 84 'obsoleteSystemInfo_, currentUpdateStatusEvent_,' +
85 'hasCheckedForUpdates_)', 85 'hasCheckedForUpdates_)',
86 'updateShowRelaunch_(currentUpdateStatusEvent_, targetChannel_)', 86 'updateShowRelaunch_(currentUpdateStatusEvent_, targetChannel_,' +
87 'currentChannel_)',
87 'updateShowButtonContainer_(' + 88 'updateShowButtonContainer_(' +
88 'showRelaunch_, showRelaunchAndPowerwash_, showCheckUpdates_)', 89 'showRelaunch_, showRelaunchAndPowerwash_, showCheckUpdates_)',
89 </if> 90 </if>
90 ], 91 ],
91 92
92 93
93 /** @private {?settings.AboutPageBrowserProxy} */ 94 /** @private {?settings.AboutPageBrowserProxy} */
94 aboutBrowserProxy_: null, 95 aboutBrowserProxy_: null,
95 96
96 /** @private {?settings.LifetimeBrowserProxy} */ 97 /** @private {?settings.LifetimeBrowserProxy} */
97 lifetimeBrowserProxy_: null, 98 lifetimeBrowserProxy_: null,
98 99
99 /** @override */ 100 /** @override */
100 attached: function() { 101 attached: function() {
101 this.aboutBrowserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance(); 102 this.aboutBrowserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
102 this.aboutBrowserProxy_.pageReady(); 103 this.aboutBrowserProxy_.pageReady();
103 104
104 this.lifetimeBrowserProxy_ = 105 this.lifetimeBrowserProxy_ =
105 settings.LifetimeBrowserProxyImpl.getInstance(); 106 settings.LifetimeBrowserProxyImpl.getInstance();
106 107
107 <if expr="chromeos"> 108 <if expr="chromeos">
108 this.addEventListener('target-channel-changed', function(e) { 109 this.addEventListener('target-channel-changed', function(e) {
109 this.targetChannel_ = e.detail; 110 this.targetChannel_ = e.detail;
110 }.bind(this)); 111 }.bind(this));
111 112
112 Promise.all([ 113 this.aboutBrowserProxy_.getChannelInfo().then(function(info) {
113 this.aboutBrowserProxy_.getCurrentChannel(), 114 this.currentChannel_ = info.currentChannel;
114 this.aboutBrowserProxy_.getTargetChannel(), 115 this.targetChannel_ = info.targetChannel;
115 ]).then(function(channels) {
116 this.currentChannel_ = channels[0];
117 this.targetChannel_ = channels[1];
118
119 this.startListening_(); 116 this.startListening_();
120 }.bind(this)); 117 }.bind(this));
121 118
122 this.aboutBrowserProxy_.getRegulatoryInfo().then(function(info) { 119 this.aboutBrowserProxy_.getRegulatoryInfo().then(function(info) {
123 this.regulatoryInfo_ = info; 120 this.regulatoryInfo_ = info;
124 }.bind(this)); 121 }.bind(this));
125 </if> 122 </if>
126 <if expr="not chromeos"> 123 <if expr="not chromeos">
127 this.startListening_(); 124 this.startListening_();
128 </if> 125 </if>
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 }); 354 });
358 }, 355 },
359 356
360 <if expr="_google_chrome"> 357 <if expr="_google_chrome">
361 /** @private */ 358 /** @private */
362 onReportIssueTap_: function() { 359 onReportIssueTap_: function() {
363 this.aboutBrowserProxy_.openFeedbackDialog(); 360 this.aboutBrowserProxy_.openFeedbackDialog();
364 }, 361 },
365 </if> 362 </if>
366 }); 363 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/about_page/about_page_browser_proxy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698