Issue 253803002: Switch from a DCHECK to RAW_LOG in base::LaunchProcess.

Issue 253803002: Switch from a DCHECK to RAW_LOG in base::LaunchProcess. (Closed)

Created:
6 years, 7 months ago by Robert Sesek

Modified:
6 years, 7 months ago

Reviewers:
jln (very slow on Chromium), willchan no longer on Chromium

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Switch from a DCHECK to RAW_LOG in base::LaunchProcess. BUG=367304 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266958

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	base/process/launch_posix.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 9 (0 generated)

jln (very slow on Chromium)

lgtm, but are you sure you don't want to just RAW_LOG(FATAL,...) ? I don't think ...

6 years, 7 months ago (2014-04-28 16:57:58 UTC) #2

willchan no longer on Chromium

LGTM, although you could probably RAW_CHECK instead. Whatever!

6 years, 7 months ago (2014-04-28 22:38:13 UTC) #4

Robert Sesek

On 2014/04/28 22:38:13, willchan wrote: > LGTM, although you could probably RAW_CHECK instead. Whatever! RAW_CHECK ...

6 years, 7 months ago (2014-04-29 14:45:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/253803002/40001

6 years, 7 months ago (2014-04-29 14:45:58 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 7 months ago (2014-04-29 21:01:22 UTC) #8

commit-bot: I haz the power

6 years, 7 months ago (2014-04-29 21:01:22 UTC) #9

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium