Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: components/sync/driver/glue/sync_backend_host_impl_unittest.cc

Issue 2538023002: [Sync] Pass a TaskRunner into SBHI/SBHC, not a thread or message loop. (Closed)
Patch Set: Remove thread check in destructor. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/glue/sync_backend_host_impl_unittest.cc
diff --git a/components/sync/driver/glue/sync_backend_host_impl_unittest.cc b/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
index 8305afdaa3da129499af8be47238b02cfd9b2baa..36469d20f3b14f6073a82a76a61081b7799fbff1 100644
--- a/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
+++ b/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
@@ -167,8 +167,7 @@ class SyncBackendHostTest : public testing::Test {
sync_prefs_ = base::MakeUnique<SyncPrefs>(&pref_service_);
sync_thread_.StartAndWaitForTesting();
backend_ = base::MakeUnique<SyncBackendHostImpl>(
- "dummyDebugName", &sync_client_, base::ThreadTaskRunnerHandle::Get(),
- nullptr, sync_prefs_->AsWeakPtr(),
+ "dummyDebugName", &sync_client_, nullptr, sync_prefs_->AsWeakPtr(),
temp_dir_.GetPath().Append(base::FilePath(kTestSyncDir)));
credentials_.account_id = "user@example.com";
credentials_.email = "user@example.com";
@@ -213,9 +212,10 @@ class SyncBackendHostTest : public testing::Test {
base::Unretained(network_resources_.get()), nullptr,
base::Bind(&EmptyNetworkTimeUpdate));
backend_->Initialize(
- &mock_frontend_, &sync_thread_, WeakHandle<JsEventHandler>(),
- GURL(std::string()), std::string(), credentials_, true, false,
- base::FilePath(), std::move(fake_manager_factory_),
+ &mock_frontend_, sync_thread_.task_runner(),
+ WeakHandle<JsEventHandler>(), GURL(std::string()), std::string(),
+ credentials_, true, false, base::FilePath(),
+ std::move(fake_manager_factory_),
MakeWeakHandle(test_unrecoverable_error_handler_.GetWeakPtr()),
base::Closure(), http_post_provider_factory_getter,
std::move(saved_nigori_state_));
« no previous file with comments | « components/sync/driver/glue/sync_backend_host_impl.cc ('k') | components/sync/driver/glue/sync_backend_host_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698