DevTools: bail out presubmit early if error after node.js or formatting checks

third_party/WebKit/Source/devtools/PRESUBMIT.py

Index: third_party/WebKit/Source/devtools/PRESUBMIT.py
diff --git a/third_party/WebKit/Source/devtools/PRESUBMIT.py b/third_party/WebKit/Source/devtools/PRESUBMIT.py
index c7ebd1a7a94f641115dc8be574b8f9da3427376a..17d1c8ab9d0656884755ad7ae69a5114b9519ab9 100644
--- a/third_party/WebKit/Source/devtools/PRESUBMIT.py
+++ b/third_party/WebKit/Source/devtools/PRESUBMIT.py
@@ -204,6 +204,9 @@ def CheckChangeOnUpload(input_api, output_api):
     results = []
     results.extend(_CheckNodeAndNPMModules(input_api, output_api))
     results.extend(_FormatDevtools(input_api, output_api))
+    if any([type(result) is output_api.PresubmitError for result in results]):

[dgozman, 2016/11/30 23:30:07]

Let's return a tuple (results, has_errors) from _FormatDevtools explicitly
instead of checking like this.

[chenwilliam, 2016/12/01 01:32:53]

Done.

+        results.extend([output_api.PresubmitError("ERROR: Bailed out of presubmit checks early because errors were found")])
+        return results
     results.extend(_CheckDevtoolsStyle(input_api, output_api))
     results.extend(_CompileDevtoolsFrontend(input_api, output_api))
     results.extend(_CheckConvertSVGToPNGHashes(input_api, output_api))