DevTools: bail out presubmit early if error after node.js or formatting checks

DevTools: bail out presubmit early if error after node.js or formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none

Committed: https://crrev.com/72d297e1b6ecdaa95bd086b9c15aad951a4cf267
Cr-Commit-Position: refs/heads/master@{#435736}

[chenwilliam, 2016-11-30 02:25:13]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2016-11-30 02:25:14]

Please take a look.

https://codereview.chromium.org/2538003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/.gitignore (right):

https://codereview.chromium.org/2538003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/.gitignore:16: /front_end/protocol_externs.js
not really related, but I've noticed it's possible to accidentally commit this
file if you run "git add" during the closure compile check

[dgozman, 2016-11-30 18:06:15]

Didn't we agree on printing out the command "please do the following to fix the
formatting" instead of changing in-place?

[chenwilliam, 2016-11-30 23:26:20]

On 2016/11/30 18:06:15, dgozman wrote:
> Didn't we agree on printing out the command "please do the following to fix
the
> formatting" instead of changing in-place?

For the changing in-place, I looked at the "git cl format" python script and I'm
planning on submitting a patch to depot_tools so it runs it on Javascript code,
but I'm a bit wary of having clang-format run on all JS files so I'll probably
need to work with an owner (either explicitly whitelist certain paths or looking
at subtrees that have a .clang-format for Javascript). In the meantime, a couple
of people have requested wanting to bail out of "git cl upload" early if there's
a formatting error, so this was a quick fix.

[dgozman, 2016-11-30 23:30:08]

https://codereview.chromium.org/2538003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/2538003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/PRESUBMIT.py:207: if any([type(result) is
output_api.PresubmitError for result in results]):
Let's return a tuple (results, has_errors) from _FormatDevtools explicitly
instead of checking like this.

[chenwilliam, 2016-12-01 01:31:46]

Description was changed from

==========
DevTools: bail out presubmit checks early if error after formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

to

==========
DevTools: bail out presubmit checks early if error after node.js or formatting
checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

[chenwilliam, 2016-12-01 01:32:33]

Description was changed from

==========
DevTools: bail out presubmit checks early if error after node.js or formatting
checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

to

==========
DevTools: bail out presubmit early if error after node.js or formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

[chenwilliam, 2016-12-01 01:32:54]

PTAL.

https://codereview.chromium.org/2538003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/2538003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/PRESUBMIT.py:207: if any([type(result) is
output_api.PresubmitError for result in results]):
On 2016/11/30 23:30:07, dgozman wrote:
> Let's return a tuple (results, has_errors) from _FormatDevtools explicitly
> instead of checking like this.

Done.

[dgozman, 2016-12-01 05:47:55]

lgtm

[chenwilliam, 2016-12-01 18:44:36]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-12-01 18:45:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 22:12:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480617876672400,
"parent_rev": "31148199fad06e74e5634834483f6888f65408fd", "commit_rev":
"83181af4b59ec591c4c0ffaf9a33bf266de155d9"}

[commit-bot: I haz the power, 2016-12-01 22:12:29]

Description was changed from

==========
DevTools: bail out presubmit early if error after node.js or formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

to

==========
DevTools: bail out presubmit early if error after node.js or formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

[commit-bot: I haz the power, 2016-12-01 22:12:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 22:14:25]

Description was changed from

==========
DevTools: bail out presubmit early if error after node.js or formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none
==========

to

==========
DevTools: bail out presubmit early if error after node.js or formatting checks

If there's a formatting error, you need to commit the formatting changes
and then re-run "git cl upload" so we just bail out of presubmit checks early
to save people time.

BUG=none

Committed: https://crrev.com/72d297e1b6ecdaa95bd086b9c15aad951a4cf267
Cr-Commit-Position: refs/heads/master@{#435736}
==========

[commit-bot: I haz the power, 2016-12-01 22:14:26]

Patchset 2 (id:??) landed as
https://crrev.com/72d297e1b6ecdaa95bd086b9c15aad951a4cf267
Cr-Commit-Position: refs/heads/master@{#435736}