Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2537983002: Make user agent set via envvar, not CLI option (Closed)

Created:
4 years ago by iannucci
Modified:
4 years ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M cipd/client/cmd/cipd/main.go View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
iannucci
4 years ago (2016-11-30 00:23:41 UTC) #1
Vadim Sh.
lgtm
4 years ago (2016-11-30 00:25:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537983002/1
4 years ago (2016-11-30 00:27:41 UTC) #4
commit-bot: I haz the power
4 years ago (2016-11-30 00:34:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/3d891f6c0233be285a79cc123c98440df5e234ec

Powered by Google App Engine
This is Rietveld 408576698