Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2537973003: One more check for PrintWebViewHelper validity. (Closed)

Created:
4 years ago by Lei Zhang
Modified:
4 years ago
Reviewers:
lfg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

One more check for PrintWebViewHelper validity. This check should have been in r434734. BUG=669534 Committed: https://crrev.com/149f2a418b32edc71ce700e75084fccf2ce6eb2a Cr-Commit-Position: refs/heads/master@{#435323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/printing/renderer/print_web_view_helper.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Lei Zhang
Just eyeballing this one.
4 years ago (2016-11-30 10:13:30 UTC) #5
lfg
lgtm
4 years ago (2016-11-30 17:00:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537973003/1
4 years ago (2016-11-30 17:46:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 17:53:26 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 17:58:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/149f2a418b32edc71ce700e75084fccf2ce6eb2a
Cr-Commit-Position: refs/heads/master@{#435323}

Powered by Google App Engine
This is Rietveld 408576698