Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2537953002: Fix a leak in a MacViews pasteboard test. (Closed)

Created:
4 years ago by erikchen
Modified:
4 years ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, dcheng, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a leak in a MacViews pasteboard test. BUG=665691 Committed: https://crrev.com/b3048cc1a9f9feb6a3f38d364cee1a79bd3fcb23 Cr-Commit-Position: refs/heads/master@{#435201}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment from tapted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/views/cocoa/drag_drop_client_mac_unittest.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
erikchen
tapted: Please review.
4 years ago (2016-11-29 22:41:48 UTC) #2
tapted
lgtm - thanks a ton! https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_client_mac_unittest.mm File ui/views/cocoa/drag_drop_client_mac_unittest.mm (right): https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_client_mac_unittest.mm#newcode13 ui/views/cocoa/drag_drop_client_mac_unittest.mm:13: #include "ui/base/clipboard/clipboard_util_mac.h" nit: import?
4 years ago (2016-11-29 23:00:37 UTC) #3
erikchen
https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_client_mac_unittest.mm File ui/views/cocoa/drag_drop_client_mac_unittest.mm (right): https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_client_mac_unittest.mm#newcode13 ui/views/cocoa/drag_drop_client_mac_unittest.mm:13: #include "ui/base/clipboard/clipboard_util_mac.h" On 2016/11/29 23:00:37, tapted wrote: > nit: ...
4 years ago (2016-11-29 23:08:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537953002/20001
4 years ago (2016-11-29 23:09:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
4 years ago (2016-11-30 01:12:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537953002/20001
4 years ago (2016-11-30 09:45:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 09:51:13 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 09:53:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3048cc1a9f9feb6a3f38d364cee1a79bd3fcb23
Cr-Commit-Position: refs/heads/master@{#435201}

Powered by Google App Engine
This is Rietveld 408576698