|
|
Chromium Code Reviews
DescriptionFix a leak in a MacViews pasteboard test.
BUG=665691
Committed: https://crrev.com/b3048cc1a9f9feb6a3f38d364cee1a79bd3fcb23
Cr-Commit-Position: refs/heads/master@{#435201}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comment from tapted. #Messages
Total messages: 15 (7 generated)
erikchen@chromium.org changed reviewers: + tapted@chromium.org
tapted: Please review.
lgtm - thanks a ton! https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_cl... File ui/views/cocoa/drag_drop_client_mac_unittest.mm (right): https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_cl... ui/views/cocoa/drag_drop_client_mac_unittest.mm:13: #include "ui/base/clipboard/clipboard_util_mac.h" nit: import?
https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_cl... File ui/views/cocoa/drag_drop_client_mac_unittest.mm (right): https://codereview.chromium.org/2537953002/diff/1/ui/views/cocoa/drag_drop_cl... ui/views/cocoa/drag_drop_client_mac_unittest.mm:13: #include "ui/base/clipboard/clipboard_util_mac.h" On 2016/11/29 23:00:37, tapted wrote: > nit: import? Done.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org Link to the patchset: https://codereview.chromium.org/2537953002/#ps20001 (title: "Comment from tapted.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480499073304060,
"parent_rev": "51bca13cecc9f74bce4eac7657430beccf618558", "commit_rev":
"6114ee786a6f230a5428e9b65e08bf0d59153504"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix a leak in a MacViews pasteboard test. BUG=665691 ========== to ========== Fix a leak in a MacViews pasteboard test. BUG=665691 Committed: https://crrev.com/b3048cc1a9f9feb6a3f38d364cee1a79bd3fcb23 Cr-Commit-Position: refs/heads/master@{#435201} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b3048cc1a9f9feb6a3f38d364cee1a79bd3fcb23 Cr-Commit-Position: refs/heads/master@{#435201} |
