Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: cc/layers/surface_layer_unittest.cc

Issue 2537943002: Getting rid of CompositorFrameMetadata::satisfies_sequences (Closed)
Patch Set: test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/surface_layer_unittest.cc
diff --git a/cc/layers/surface_layer_unittest.cc b/cc/layers/surface_layer_unittest.cc
index 5b688676e02ccd34764232b9f6f1f5e0bc052fec..4005de8b4cf491b831e41d83480007585ac3c198 100644
--- a/cc/layers/surface_layer_unittest.cc
+++ b/cc/layers/surface_layer_unittest.cc
@@ -203,6 +203,7 @@ class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {
layer_tree()->SetRootLayer(blank_layer_);
break;
case 2:
+ EndTest();
break;
default:
NOTREACHED();
@@ -210,28 +211,12 @@ class SurfaceLayerSwapPromiseWithDraw : public SurfaceLayerSwapPromise {
}
}
- void DisplayReceivedCompositorFrameOnThread(
- const CompositorFrame& frame) override {
- const std::vector<uint32_t>& satisfied = frame.metadata.satisfies_sequences;
- EXPECT_LE(satisfied.size(), 1u);
- if (satisfied.size() == 1) {
- // Eventually the one SurfaceSequence should be satisfied, but only
- // after the layer was removed from the tree, and only once.
- EXPECT_EQ(1u, satisfied[0]);
- EXPECT_LE(1, commit_count_);
- EXPECT_FALSE(sequence_was_satisfied_);
- sequence_was_satisfied_ = true;
- EndTest();
- }
- }
-
void AfterTest() override {
EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryFrameSinkId,
LocalFrameId(1, kArbitraryToken)));
EXPECT_EQ(1u, required_set_.size());
- // Sequence should have been satisfied through Swap, not with the
- // callback.
- EXPECT_FALSE(satisfied_sequence_.is_valid());
+ EXPECT_TRUE(satisfied_sequence_ ==
+ SurfaceSequence(kArbitraryFrameSinkId, 1u));
}
};
@@ -269,7 +254,6 @@ class SurfaceLayerSwapPromiseWithoutDraw : public SurfaceLayerSwapPromise {
EXPECT_TRUE(required_id_ == SurfaceId(kArbitraryFrameSinkId,
LocalFrameId(1, kArbitraryToken)));
EXPECT_EQ(1u, required_set_.size());
- // Sequence should have been satisfied with the callback.
EXPECT_TRUE(satisfied_sequence_ ==
SurfaceSequence(kArbitraryFrameSinkId, 1u));
}

Powered by Google App Engine
This is Rietveld 408576698