Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2537923002: Deprecate Net.Socket.IdleSocketTimeSaving (Closed)

Created:
4 years ago by xunjieli
Modified:
4 years ago
Reviewers:
Ilya Sherman, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, eroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate Net.Socket.IdleSocketTimeSaving Net.Socket.IdleSocketTimeSaving histogram isn't measuring what it is supposed to measure, see https://codereview.chromium.org/2533063002 for more info. This CL removes this histogram. R=mmenke@chromium.org Committed: https://crrev.com/d4e78f285ae0984f33ce5d0d1799089294455247 Cr-Commit-Position: refs/heads/master@{#435612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M net/socket/client_socket_pool_base.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
xunjieli
4 years ago (2016-11-29 21:19:21 UTC) #1
mmenke
LGTM
4 years ago (2016-11-30 15:18:05 UTC) #6
xunjieli
isherman@: PTAL at histograms.xml. Thanks!
4 years ago (2016-11-30 15:19:20 UTC) #8
Ilya Sherman
histograms.xml lgtm, thanks
4 years ago (2016-11-30 23:08:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537923002/1
4 years ago (2016-12-01 14:33:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 15:26:44 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 15:28:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e78f285ae0984f33ce5d0d1799089294455247
Cr-Commit-Position: refs/heads/master@{#435612}

Powered by Google App Engine
This is Rietveld 408576698