Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2537893003: Scroll IME list to visible when using tab key. (Closed)

Created:
4 years ago by Azure Wei
Modified:
4 years ago
Reviewers:
tdanderson
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scroll IME list to visible when using tab key. When switches the focused IME item with Tab key, scroll the IME detailed view to make the focused item visible. BUG=668035 TEST=Verified on local build. Committed: https://crrev.com/c5f7e4111cf2110cc972a4d7bcb8f90651dfcae6 Cr-Commit-Position: refs/heads/master@{#435494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Azure Wei
Please review this CL. Thanks!
4 years ago (2016-11-30 11:15:35 UTC) #5
tdanderson
LGTM
4 years ago (2016-11-30 22:57:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537893003/1
4 years ago (2016-12-01 00:27:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 00:35:13 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 00:39:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5f7e4111cf2110cc972a4d7bcb8f90651dfcae6
Cr-Commit-Position: refs/heads/master@{#435494}

Powered by Google App Engine
This is Rietveld 408576698