Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2537883002: Don't attempt to record reference to a named parameter of a synthetic function. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't attempt to record reference to a named parameter of a synthetic function. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/86866a31166406180ed90ce0fb4b3dbb0648b8fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/index.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/index_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years ago (2016-11-29 19:28:51 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-11-29 19:37:36 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 86866a31166406180ed90ce0fb4b3dbb0648b8fe (presubmit successful).
4 years ago (2016-11-29 19:42:01 UTC) #4
Paul Berry
4 years ago (2016-11-29 20:11:40 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698