Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2537873002: [Chromecast] Suppress a crashing lint warning. (Closed)

Created:
4 years ago by Simeon
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Suppress a crashing lint warning. The new linter fails on a specific warning it encounters in old Chromecast code that will soon be removed. Suppress the check on that file for now until the whole library that contains it can be removed. BUG=Internal b/32980831 Committed: https://crrev.com/477db25e38327a2891aa3c02e1b112d0308f9306 Cr-Commit-Position: refs/heads/master@{#435737}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add link to tracking bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/android/lint/suppressions.xml View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Simeon
4 years ago (2016-11-29 19:36:22 UTC) #2
slan
https://codereview.chromium.org/2537873002/diff/1/build/android/lint/suppressions.xml File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2537873002/diff/1/build/android/lint/suppressions.xml#newcode462 build/android/lint/suppressions.xml:462: <!-- TODO(sanfin): Remove this when the Chromecast dependency on ...
4 years ago (2016-11-29 19:42:18 UTC) #3
Simeon
4 years ago (2016-11-29 19:42:38 UTC) #5
Simeon
On 2016/11/29 19:42:18, slan wrote: > https://codereview.chromium.org/2537873002/diff/1/build/android/lint/suppressions.xml > File build/android/lint/suppressions.xml (right): > > https://codereview.chromium.org/2537873002/diff/1/build/android/lint/suppressions.xml#newcode462 > ...
4 years ago (2016-11-29 20:01:33 UTC) #6
slan
lgtm, but mikecase must sign off.
4 years ago (2016-11-29 20:19:34 UTC) #7
Simeon
On 2016/11/29 20:19:34, slan wrote: > lgtm, but mikecase must sign off. ping
4 years ago (2016-12-01 20:23:51 UTC) #8
mikecase (-- gone --)
lgtm
4 years ago (2016-12-01 20:43:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537873002/20001
4 years ago (2016-12-01 20:55:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 22:23:36 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 22:25:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/477db25e38327a2891aa3c02e1b112d0308f9306
Cr-Commit-Position: refs/heads/master@{#435737}

Powered by Google App Engine
This is Rietveld 408576698