Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2537863003: Remove [ConstructorCallWith=ScriptState] from Sensor (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
Yuki, Mikhail
CC:
chromium-reviews, blink-reviews, haraken, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [ConstructorCallWith=ScriptState] from Sensor We're deprecating [ConstructorCallWith=ScriptState] since it can lead to a programming error that leaks ScriptStates to other worlds (see the bug). This CL replaces it with [ConstructorCallWith=ExecutionContext]. BUG=669812 Committed: https://crrev.com/346fe565b766ec090e9dd444b03542b02bab732a Cr-Commit-Position: refs/heads/master@{#435217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -51 lines) Patch
M third_party/WebKit/Source/modules/sensor/Accelerometer.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Accelerometer.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp View 1 chunk +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.h View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Gyroscope.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Magnetometer.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
haraken
PTAL
4 years ago (2016-11-30 09:43:08 UTC) #2
Yuki
lgtm
4 years ago (2016-11-30 09:55:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537863003/1
4 years ago (2016-11-30 09:55:36 UTC) #5
Mikhail
lgtm
4 years ago (2016-11-30 10:29:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 11:25:30 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 11:27:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/346fe565b766ec090e9dd444b03542b02bab732a
Cr-Commit-Position: refs/heads/master@{#435217}

Powered by Google App Engine
This is Rietveld 408576698