Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2537813003: Insert logcat as part of test result for android instrumentation tests. (Closed)

Created:
4 years ago by BigBossZhiling
Modified:
4 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Insert logcat as part of test result for android instrumentation tests. In this cl, we are trying to add the logcat of each instrumentation test into the corresponding test result object, so that when we are checking the result of each test case, we would be able to see the corresponding logcat for that test case at the same time. BUG=631213 Committed: https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e Cr-Commit-Position: refs/heads/master@{#435247}

Patch Set 1 #

Patch Set 2 : insert sawrming_client to the front #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -3 lines) Patch
A build/android/pylib/android/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A build/android/pylib/android/logdog_logcat_monitor.py View 1 1 chunk +83 lines, -0 lines 0 comments Download
M build/android/pylib/base/base_test_result.py View 2 chunks +7 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 3 chunks +10 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +14 lines, -3 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
BigBossZhiling
4 years ago (2016-11-29 22:02:14 UTC) #3
jbudorick
lgtm
4 years ago (2016-11-29 22:05:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537813003/20001
4 years ago (2016-11-29 22:14:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-30 00:17:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537813003/20001
4 years ago (2016-11-30 00:50:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-30 02:52:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537813003/20001
4 years ago (2016-11-30 14:00:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 14:04:31 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e Cr-Commit-Position: refs/heads/master@{#435247}
4 years ago (2016-11-30 14:07:27 UTC) #19
jbudorick
4 years ago (2016-11-30 18:47:35 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2541113002/ by jbudorick@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/chromium/issues/detail?id=669989.

Powered by Google App Engine
This is Rietveld 408576698