Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 2537813002: Update `num.compareTo` documentation. (Closed)

Created:
4 years ago by floitsch
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rewrite parts of the update #

Total comments: 6

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M sdk/lib/core/num.dart View 1 2 1 chunk +31 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
4 years ago (2016-11-29 14:24:13 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/2537813002/diff/20001/sdk/lib/core/num.dart File sdk/lib/core/num.dart (right): https://codereview.chromium.org/2537813002/diff/20001/sdk/lib/core/num.dart#newcode77 sdk/lib/core/num.dart:77: * - NaN is equal to itself, and ...
4 years ago (2016-11-29 15:59:21 UTC) #3
floitsch
https://codereview.chromium.org/2537813002/diff/20001/sdk/lib/core/num.dart File sdk/lib/core/num.dart (right): https://codereview.chromium.org/2537813002/diff/20001/sdk/lib/core/num.dart#newcode77 sdk/lib/core/num.dart:77: * - NaN is equal to itself, and greater ...
4 years ago (2016-12-02 01:26:56 UTC) #4
floitsch
4 years ago (2016-12-02 01:27:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
db8782f6e66435854d2d1a364769351327fffc2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698