Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2537773006: Extract a QuicSpdyServerStreamBase class for code sharing between QuicSimpleServerStream and GfeQui… (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract a QuicSpdyServerStreamBase class for code sharing between QuicSimpleServerStream and GfeQuicServerStream. Move QuicSpdyStream::CloseWriteSide() into QuicServerStreamBase because what it does is only intended for server side. Merge internal change: 139781425 BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -17 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/tools/quic/quic_spdy_server_stream_base.h View 1 chunk +26 lines, -0 lines 1 comment Download
A net/tools/quic/quic_spdy_server_stream_base.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A net/tools/quic/quic_spdy_server_stream_base_test.cc View 1 chunk +65 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2550453002 Patch 1

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
4 years ago (2016-12-01 21:14:04 UTC) #2
Zhongyi Shi
lgtm https://codereview.chromium.org/2537773006/diff/1/net/tools/quic/quic_spdy_server_stream_base.h File net/tools/quic/quic_spdy_server_stream_base.h (right): https://codereview.chromium.org/2537773006/diff/1/net/tools/quic/quic_spdy_server_stream_base.h#newcode12 net/tools/quic/quic_spdy_server_stream_base.h:12: class QuicSpdyServerStreamBase : public QuicSpdyStream { nit: you ...
4 years ago (2016-12-01 21:58:17 UTC) #3
Ryan Hamilton
4 years ago (2016-12-01 23:31:25 UTC) #4 
On 2016/12/01 21:58:17, Zhongyi Shi wrote:
> lgtm
> 
>
https://codereview.chromium.org/2537773006/diff/1/net/tools/quic/quic_spdy_se...
> File net/tools/quic/quic_spdy_server_stream_base.h (right):
> 
>
https://codereview.chromium.org/2537773006/diff/1/net/tools/quic/quic_spdy_se...
> net/tools/quic/quic_spdy_server_stream_base.h:12: class
QuicSpdyServerStreamBase
> : public QuicSpdyStream {
> nit: you might need to add NET_EXPORT_PRIVATE either here or in the landing
cl.

It turns out not to be needed because this is not part of net proper, so it
doesn't have to be linked from one dll to another. boggle.

Powered by Google App Engine
This is Rietveld 408576698