Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2537773005: Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun. (Closed)

Created:
4 years ago by tmartino
Modified:
4 years ago
Reviewers:
Mathieu
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Moving new First Run to use per-profile value, rather than simply checking IsChromeFirstRun. This solves several edge cases described in the bug. BUG=660159 NOTRY=TRUE NOPRESUBMIT=TRUE Review-Url: https://codereview.chromium.org/2487553002 Cr-Commit-Position: refs/heads/master@{#433466} (cherry picked from commit 6254f4715b9a55b9dac805d432ce9f33376d65d6)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -22 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.h View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 5 chunks +28 lines, -8 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 2 chunks +23 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/welcome_ui.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537773005/1
4 years ago (2016-12-01 18:06:49 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-01 18:06:51 UTC) #5
Mathieu
rubber stamp lgtm
4 years ago (2016-12-01 18:09:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537773005/1
4 years ago (2016-12-01 18:10:04 UTC) #9
commit-bot: I haz the power
Failed to commit the patch.
4 years ago (2016-12-01 18:20:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537773005/1
4 years ago (2016-12-02 17:43:20 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-02 17:44:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698