Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2537763002: [turbofan] Also optimize instanceof with bound functions. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also optimize instanceof with bound functions. For bound functions on the right-hand side of instanceof we can constant-fold to the actual [[BoundTargetFunction]], actually instance OrdinaryHasInstance. Move the Function.prototype[@@hasInstance] reduction up to the JSCallReducer to allow this optimization to become effective (and also enable other optimizations). BUG=v8:5267 R=jarin@chromium.org Committed: https://crrev.com/719d6c1d58b54c08fc02c7fb3c6afb449ac93c13 Cr-Commit-Position: refs/heads/master@{#41352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -33 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/compiler/js-call-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +29 lines, -1 line 0 comments Download
A test/mjsunit/compiler/instanceof-opt3.js View 1 chunk +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
4 years ago (2016-11-29 10:34:01 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a simple follow-up optimization to also handle right-hand side bound functions for ...
4 years ago (2016-11-29 10:35:24 UTC) #4
Jarin
lgtm
4 years ago (2016-11-29 11:55:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537763002/1
4 years ago (2016-11-29 11:56:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 11:58:29 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 11:59:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/719d6c1d58b54c08fc02c7fb3c6afb449ac93c13
Cr-Commit-Position: refs/heads/master@{#41352}

Powered by Google App Engine
This is Rietveld 408576698