Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: content/renderer/fetchers/resource_fetcher_impl.cc

Issue 2537753002: Remove WebURLLoader* argument from WebURLLoaderClient methods (Closed)
Patch Set: a Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/fetchers/resource_fetcher_impl.cc
diff --git a/content/renderer/fetchers/resource_fetcher_impl.cc b/content/renderer/fetchers/resource_fetcher_impl.cc
index 833168915a316309f79feccbaea31655a933aac0..21da5c940b054256a67341a371ae399c86592a43 100644
--- a/content/renderer/fetchers/resource_fetcher_impl.cc
+++ b/content/renderer/fetchers/resource_fetcher_impl.cc
@@ -71,20 +71,16 @@ class ResourceFetcherImpl::ClientImpl : public blink::WebURLLoaderClient {
}
// WebURLLoaderClient methods:
- void didReceiveResponse(blink::WebURLLoader* loader,
- const blink::WebURLResponse& response) override {
+ void didReceiveResponse(const blink::WebURLResponse& response) override {
DCHECK(!completed_);
response_ = response;
}
- void didReceiveCachedMetadata(blink::WebURLLoader* loader,
- const char* data,
- int data_length) override {
+ void didReceiveCachedMetadata(const char* data, int data_length) override {
DCHECK(!completed_);
DCHECK_GT(data_length, 0);
}
- void didReceiveData(blink::WebURLLoader* loader,
- const char* data,
+ void didReceiveData(const char* data,
int data_length,
int encoded_data_length) override {
DCHECK(!completed_);
@@ -92,16 +88,14 @@ class ResourceFetcherImpl::ClientImpl : public blink::WebURLLoaderClient {
data_.append(data, data_length);
}
- void didFinishLoading(blink::WebURLLoader* loader,
- double finishTime,
+ void didFinishLoading(double finishTime,
int64_t total_encoded_data_length,
int64_t total_encoded_body_length) override {
DCHECK(!completed_);
OnLoadCompleteInternal(LOAD_SUCCEEDED);
}
- void didFail(blink::WebURLLoader* loader,
- const blink::WebURLError& error,
+ void didFail(const blink::WebURLError& error,
int64_t total_encoded_data_length,
int64_t total_encoded_body_length) override {
OnLoadCompleteInternal(LOAD_FAILED);
« no previous file with comments | « content/child/web_url_loader_impl_unittest.cc ('k') | third_party/WebKit/Source/core/fetch/ImageResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698